-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
array tests: handle different hexdigests from zlib-ng (#1678) #1972
base: main
Are you sure you want to change the base?
Conversation
d883b61
to
b428945
Compare
b428945
to
375bb63
Compare
If I run |
Thanks for the fix. For posterity, the ideal way to handle two different versions of zlib would be to condition the test case on the detected zlib version, but our test design makes that very tedious and not worth the effort. I think what you have done here is good! |
we are seeing test failures due to numpy 2.0 I think |
yeah, it looks like numpy got some custom types. I guess you might need to do stuff like:
or something along those lines. |
I guess the NumPy stuff was fixed by #2073, so this might just need a rebase. |
…s#1678) As explained in the issue, zlib-ng produces different hex digests from original zlib. This adjusts the tests slightly to allow for this. Signed-off-by: Adam Williamson <awilliam@redhat.com>
375bb63
to
d6aed0d
Compare
Rebased. |
As explained in the issue, zlib-ng produces different hex digests from original zlib. This adjusts the tests slightly to allow for this.
TODO:
Removed TODO items are irrelevant as this only changes tests. This is more or less the same as #1971 , but for the main (v2) branch rather than v3 branch.