Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to JavaScript with JSDoc? #68

Closed
timonson opened this issue May 14, 2022 · 2 comments
Closed

Moving to JavaScript with JSDoc? #68

timonson opened this issue May 14, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@timonson
Copy link
Member

timonson commented May 14, 2022

By moving to JavaScript including JSDoc we could make djwt compatible with the browser. By adding // @ts-check to the top of the files, it is my understanding that type checks would be executed in importing TypeScript files even if the developer would not have enabled the compiler option "checkJs" inside his deno.json file.

Am I overlooking any disadvantages or problems here?

Thanks!

@timonson timonson added enhancement New feature or request question Further information is requested labels May 14, 2022
@timonson timonson changed the title Move to JSDoc? Moving to JavaScript with JSDoc? May 14, 2022
@timonson timonson added the help wanted Extra attention is needed label May 14, 2022
@timonson
Copy link
Member Author

timonson commented Jun 3, 2022

This approach wouldn't work with the TypeScript dependency base64url from std.

@timonson timonson closed this as completed Jun 6, 2022
@timonson timonson reopened this Jun 6, 2022
@lucsoft
Copy link

lucsoft commented Nov 7, 2022

Don't do this. Stripping types is also very simple and the Deno guys want this stripping types feature also build in into deno.land/x.

I think it's a downgrade (IMO) as JSDocs also makes code less readable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants