Skip to content

CI: Check workflows and actions with zizmor - #1679

Merged
nuttycom merged 3 commits into
mainfrom
ci-zizmor
Feb 7, 2025
Merged

CI: Check workflows and actions with zizmor#1679
nuttycom merged 3 commits into
mainfrom
ci-zizmor

Conversation

@str4d

@str4d str4d commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

We don't need to run authenticated git commands.
@str4d str4d changed the title CI: Add workflow that runs zizmor latest CI: Check workflows and actions with zizmor Jan 9, 2025
@str4d
str4d force-pushed the ci-zizmor branch 2 times, most recently from 8a65c78 to 81be266 Compare January 9, 2025 17:13
@str4d

str4d commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

I can't figure out how to get a working CI with ${{ steps.prepare.outputs.feature-flags }} expansion routed through an env variable. It seems that single quotes within an env variable are not preserved. For now I'm leaving those unaddressed.

@codecov

codecov Bot commented Jan 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.22%. Comparing base (5651d80) to head (81be266).
Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1679   +/-   ##
=======================================
  Coverage   52.22%   52.22%           
=======================================
  Files         179      179           
  Lines       21353    21353           
=======================================
  Hits        11152    11152           
  Misses      10201    10201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

push:
branches: ["main"]
pull_request:
branches: ["*"]

@daira daira Feb 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: ["*"]
branches: ["**"]

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

*: Matches zero or more characters, but does not match the / character. For example, Octo* matches Octocat.
**: Matches zero or more of any character.

** is suggested here: https://woodruffw.github.io/zizmor/usage/#integration
In practice we do use branch names containing /.

@daira daira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with suggestion.

@nuttycom nuttycom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom
nuttycom merged commit c4f241f into main Feb 7, 2025
@nuttycom
nuttycom deleted the ci-zizmor branch February 7, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants