Update test vectors for ZIP 244 changes #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signatures for shielded inputs also commit to these new commitments, meaning that for mixed transactions, shielded signatures are no longer equivalent to signing the txid. This property remains for fully shielded transactions.
str4d
commented
Jan 7, 2022
Comment on lines
+403
to
+405
| ('amounts', '[i64; %d]' % len(t_inputs)), | ||
| ('script_codes', { | ||
| 'rust_type': '[Vec<u8>; %d]' % len(t_inputs), |
There was a problem hiding this comment.
Kris noted that this causes a bug in the output, because len(t_inputs) returns the length for the last test vector, but it varies across them. This should be:
Suggested change
| ('amounts', '[i64; %d]' % len(t_inputs)), | |
| ('script_codes', { | |
| 'rust_type': '[Vec<u8>; %d]' % len(t_inputs), | |
| ('amounts', 'Vec<i64>'), | |
| ('script_codes', { | |
| 'rust_type': 'Vec<Vec<u8>>', |
but that won't work without more changes to the Rust output renderer, so instead I'm going to overhaul the latter after this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57.