Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test vectors for ZIPs 143, 243, 244, and 316 #68

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Add test vectors for ZIPs 143, 243, 244, and 316 #68

merged 1 commit into from
Jan 13, 2022

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Jan 13, 2022 •
edited by str4d
Loading

No description provided.

@str4d str4d changed the title Add generated test vectors for zip_143, zip_243, zip_244, unified add… Add test vectors for ZIPs 143, 243, 244, and 316 Jan 13, 2022
str4d
str4d requested changes Jan 13, 2022
View reviewed changes
regenerate.sh Outdated Show resolved Hide resolved
@str4d str4d added this to the Core Sprint 2021-52 milestone Jan 13, 2022
str4d
str4d approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I verified that I generated the same Rust and JSON test vectors (I didn't check the Bitcoin-flavoured ones).

@str4d str4d merged commit 1ce0af7 into zcash:master Jan 13, 2022
@nuttycom nuttycom deleted the add_missing_test_vectors branch January 13, 2022 02:09
daira
daira reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Core Sprint 2021-52
Development

Successfully merging this pull request may close these issues.
3 participants
@nuttycom @daira @str4d