Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equihash: Return valid solutions immediately #1143

Closed
str4d opened this issue Jul 26, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@str4d
Copy link
Contributor

commented Jul 26, 2016

Currently, the Equihash solver collects all valid solutions from a solver run and then returns them as a vector. We should instead pass in a callback to the solver to check obtained solutions against the difficulty immediately (the same way we have the cancelled callback).

@str4d str4d self-assigned this Jul 26, 2016

str4d added a commit to str4d/zcash that referenced this issue Jul 27, 2016

zkbot pushed a commit that referenced this issue Jul 29, 2016

zkbot
Auto merge of #1146 - str4d:1143-equihash-solution-callback, r=str4d
Equihash: Pass each obtained solution to a callback for immediate checking

Closes #1143

zkbot pushed a commit that referenced this issue Jul 30, 2016

zkbot
Auto merge of #1146 - str4d:1143-equihash-solution-callback, r=ebfull
Equihash: Pass each obtained solution to a callback for immediate checking

Closes #1143

@zkbot zkbot closed this in #1146 Jul 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.