Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCC-2016-002 - Direct memory leak #1221

Closed
rcseacord opened this issue Aug 10, 2016 · 1 comment
Closed

NCC-2016-002 - Direct memory leak #1221

rcseacord opened this issue Aug 10, 2016 · 1 comment
Labels
C-audit Category: Issues and tasks related to audit findings I-dos Problems and improvements with respect to Denial-of-Service. I-SECURITY Problems and improvements related to security. M-suggested-to-close We should consider closing this issue or PR. memory management

Comments

@rcseacord
Copy link
Contributor

Direct leak of 181161024 byte(s) in 1 object(s) allocated from:
#0 0x55d5292fadb0 in operator new(unsigned long) (/home/rcs/Test/zcash/zcash/src/test/test_bitcoin+0x14fdb0)
#1 0x55d529a12ebd in _gnu_cxx::new_allocatorlibsnark::alt_bn128_G1::allocate(unsigned long, void const) /usr/include/c++/6/ext/new_allocator.h:104
#2 0x55d529a12ebd in std::allocator_traitsstd::allocator<libsnark::alt_bn128_G1 >::allocate(std::allocatorlibsnark::alt_bn128_G1&, unsigned long) /usr/include/c++/6/bits/alloc_traits.h:416
#3 0x55d529a12ebd in std::_Vector_base<libsnark::alt_bn128_G1, std::allocatorlibsnark::alt_bn128_G1 >::_M_allocate(unsigned long) /usr/include/c++/6/bits/stl_vector.h:170
#4 0x55d529a12ebd in std::_Vector_base<libsnark::alt_bn128_G1, std::allocatorlibsnark::alt_bn128_G1 >::M_create_storage(unsigned long) /usr/include/c++/6/bits/stl_vector.h:185
#5 0x55d529a12ebd in std::Vector_base<libsnark::alt_bn128_G1, std::allocatorlibsnark::alt_bn128_G1 >::Vector_base(unsigned long, std::allocatorlibsnark::alt_bn128_G1 const&) /usr/include/c++/6/bits/stl_vector.h:136
#6 0x55d529a12ebd in std::vector<libsnark::alt_bn128_G1, std::allocatorlibsnark::alt_bn128_G1 >::vector(std::vector<libsnark::alt_bn128_G1, std::allocatorlibsnark::alt_bn128_G1 > const&) /usr/include/c++/6/bits/stl_vector.h:322
#7 0x55d529a12ebd in libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp::r1cs_ppzksnark_proving_key(libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp const&) /home/rcs/Test/zcash/zcash/depends/x86_64-unknown-linux-gnu/include/libsnark/zk_proof_systems/ppzksnark/r1cs_ppzksnark/r1cs_ppzksnark.hpp:84
#8 0x55d529a12ebd in void boost::optional_detail::optional_baselibsnark::r1cs_ppzksnark_proving_key<libsnark::alt_bn128_pp >::constructlibsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp&(libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp&, void const) /home/rcs/Test/zcash/zcash/depends/x86_64-unknown-linux-gnu/include/boost/optional/optional.hpp:595
#9 0x55d529a12ebd in void boost::optional_detail::optional_baselibsnark::r1cs_ppzksnark_proving_key<libsnark::alt_bn128_pp >::assign_exprlibsnark::r1cs_ppzksnark_proving_key<libsnark::alt_bn128_pp&, libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp >(libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp&, libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp const) /home/rcs/Test/zcash/zcash/depends/x86_64-unknown-linux-gnu/include/boost/optional/optional.hpp:430
#10 0x55d529a12ebd in boost::disable_if_c<boost::is_base_of<boost::optional_detail::optional_tag, boost::decay<libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp&>::type>::value||boost::is_sameboost::decay<libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp&::type, int boost::detail::none_helper::>::value, boost::optionallibsnark::r1cs_ppzksnark_proving_key<libsnark::alt_bn128_pp >&>::type boost::optionallibsnark::r1cs_ppzksnark_proving_key<libsnark::alt_bn128_pp >::operator=libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp&(libsnark::r1cs_ppzksnark_proving_keylibsnark::alt_bn128_pp&) /home/rcs/Test/zcash/zcash/depends/x86_64-unknown-linux-gnu/include/boost/optional/optional.hpp:870
#11 0x55d529a12ebd in libzcash::JoinSplitCircuit<2ul, 2ul>::generate() zcash/JoinSplit.cpp:121
@daira daira changed the title Direct memory leak NCC-2016-002 - Direct memory leak Sep 30, 2016
@daira daira added NCC finding I-dos Problems and improvements with respect to Denial-of-Service. memory management I-SECURITY Problems and improvements related to security. labels Nov 11, 2017
@str4d str4d added C-audit Category: Issues and tasks related to audit findings M-suggested-to-close We should consider closing this issue or PR. and removed NCC finding labels Aug 17, 2020
@nuttycom
Copy link
Contributor

libsnark is no longer a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-audit Category: Issues and tasks related to audit findings I-dos Problems and improvements with respect to Denial-of-Service. I-SECURITY Problems and improvements related to security. M-suggested-to-close We should consider closing this issue or PR. memory management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nuttycom @daira @rcseacord @str4d @zebambam