reject block versions < 4 #1556

Closed
daira opened this Issue Oct 18, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@daira
Contributor

daira commented Oct 18, 2016

The spec currently says that versions < 4 are rejected. We must either do that, or change the spec.

Note that code inherited from Bitcoin might do unintended things for lower block versions; by enforcing this rule, we would be reducing the number of code paths and improving auditability.

@daira daira added this to the 1.0.0-rc2 milestone Oct 18, 2016

@daira daira self-assigned this Oct 18, 2016

@daira daira added the protocol spec label Oct 18, 2016

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Oct 18, 2016

Contributor

The history of block versions in Bitcoin is documented at https://bitcoin.org/en/developer-reference#block-versions .

Contributor

daira commented Oct 18, 2016

The history of block versions in Bitcoin is documented at https://bitcoin.org/en/developer-reference#block-versions .

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Oct 19, 2016

Contributor

Resolving this may require rebuilding the genesis block.

Contributor

str4d commented Oct 19, 2016

Resolving this may require rebuilding the genesis block.

@str4d str4d self-assigned this Oct 20, 2016

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Oct 20, 2016

Contributor

This definitely requires rebuilding the genesis block. I'm going to hold off making a PR for this issue until #1578 (or later equivalent) is merged.

Contributor

str4d commented Oct 20, 2016

This definitely requires rebuilding the genesis block. I'm going to hold off making a PR for this issue until #1578 (or later equivalent) is merged.

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Oct 21, 2016

Contributor

@str4d #1578 is merging now.

Contributor

daira commented Oct 21, 2016

@str4d #1578 is merging now.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Oct 21, 2016

Contributor

Merged, working on a PR for this now.

Contributor

str4d commented Oct 21, 2016

Merged, working on a PR for this now.

str4d added a commit to str4d/zcash that referenced this issue Oct 22, 2016

@str4d str4d added the has PR label Oct 22, 2016

zkbot pushed a commit that referenced this issue Oct 22, 2016

zkbot
Auto merge of #1603 - str4d:1556-reject-old-block-versions, r=daira
Reject block versions lower than 4

Includes parts of #1554
Closes #1556

zkbot pushed a commit that referenced this issue Oct 22, 2016

zkbot
Auto merge of #1603 - str4d:1556-reject-old-block-versions, r=daira
Reject block versions lower than 4

Includes parts of #1554
Closes #1556

@zkbot zkbot closed this in #1603 Oct 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment