Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more/better TestEquihashValidator vectors #1825

solardiz opened this issue Nov 8, 2016 · 0 comments

Need more/better TestEquihashValidator vectors #1825

solardiz opened this issue Nov 8, 2016 · 0 comments


Copy link

@solardiz solardiz commented Nov 8, 2016

As discussed with @str4d, we need to more thoroughly test IsValidSolution(), in particular with duplicate indices. The current two expected-failure tests for duplicate indices are for trivial special cases, and they might not detect some plausible bugs in the dupe check.

We need to add some test vectors with just one pair of non-adjacent duplicate indices per test vector, and such that they would be expected to pass validation if it were not for the dupe check.

We also need to have the tests distinguish between the different "return false;" and require that the expected one be triggered. This requires a change to the function prototype or some out-of-band means to communicate this detail specifically to the unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Security and Stability
Work Queue
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.