Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UPnP support #2500

Closed
bitcartel opened this issue Jul 1, 2017 · 3 comments
Closed

Remove UPnP support #2500

bitcartel opened this issue Jul 1, 2017 · 3 comments
Assignees
Labels
A-networking Area: Networking code C-upstream-port Category: Changes that are ported from the Bitcoin Core codebase. I-SECURITY Problems and improvements related to security.

Comments

@bitcartel
Copy link
Contributor

bitcartel commented Jul 1, 2017

https://bitcoin.org/en/release/v0.14.2#miniupnp-cve-2017-8798

bitcoin/bitcoin#10414

@bitcartel bitcartel added A-networking Area: Networking code I-SECURITY Problems and improvements related to security. C-upstream-port Category: Changes that are ported from the Bitcoin Core codebase. labels Jul 1, 2017
@bitcartel bitcartel added this to the 1.0.11 Release milestone Jul 1, 2017
@bitcartel bitcartel assigned daira and str4d and unassigned daira and str4d Jul 1, 2017
bitcartel added a commit to bitcartel/zcash that referenced this issue Jul 1, 2017
@daira
Copy link
Contributor

daira commented Jul 2, 2017

We should also consider just stripping out the -upnp option and miniupnpc dependency.

@daira
Copy link
Contributor

daira commented Jul 2, 2017

Note that UPnP has been disabled in Bitcoin by default since 0.10.3, i.e. before we forked. I've confirmed that it is also disabled by default in Zcash.

@daira daira removed this from the 1.0.11 Release milestone Jul 3, 2017
@daira daira changed the title Evaluate and backport upstream fix for miniupnpc if necessary Either backport upstream fix for miniupnpc, or remove UPnP support Jul 3, 2017
@daira daira added this to Work Queue in Security and Stability Jul 3, 2017
@daira daira moved this from Work Queue to In Progress in Security and Stability Jul 3, 2017
@nathan-at-least nathan-at-least moved this from Work Queue to Nominated for Release in Development Infrastructure Jul 3, 2017
@daira
Copy link
Contributor

daira commented Jul 4, 2017

@radix42 writes on #zcash-dev:

I don't know of anyone using upnp support and none of my [Windows and OS X] releases turn it on explicitly, so if its off by default, then my users do not care (and it has been causing trouble with getting zcash ported to the BSD's, too)

so I"m all for ditching it

@daira daira added this to the 1.0.11 Release milestone Jul 6, 2017
@nathan-at-least nathan-at-least changed the title Either backport upstream fix for miniupnpc, or remove UPnP support Remove UPnP support Jul 10, 2017
@daira daira moved this from In Progress to Awaiting Review in Security and Stability Jul 14, 2017
zkbot added a commit that referenced this issue Jul 16, 2017
Remove UPnP support. fixes #2500

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@zkbot zkbot closed this as completed in 506a218 Jul 16, 2017
@str4d str4d moved this from Nominated for Release to Complete in Development Infrastructure Aug 1, 2017
@str4d str4d moved this from Awaiting Review to Complete in Security and Stability Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Area: Networking code C-upstream-port Category: Changes that are ported from the Bitcoin Core codebase. I-SECURITY Problems and improvements related to security.
Projects
No open projects
Development

No branches or pull requests

3 participants