Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

study feasibility of reducing libsnark memory usage for proving #750

Closed
daira opened this issue Mar 3, 2016 · 4 comments · Fixed by #4060

Comments

@daira
Copy link
Contributor

@daira daira commented Mar 3, 2016

This ticket covers ways of reducing memory usage of proving by implementation changes to libsnark, other than changing the circuit.

See also:

  • #561 investigate whether the zkSNARK can use only x coordinates (or only y coordinates)
  • #748 Buildbot Performance Measurement
  • #605 Add --debug=libsnark-profiling option.
  • #251 Benchmark and document the time/memory tradeoff of LOWMEM=1
  • #2235 Stream the proving key to reduce memory usage

It does not cover computing the witness which was #20 and #473 (done).

@ebfull

This comment has been minimized.

Copy link
Contributor

@ebfull ebfull commented Apr 26, 2016

Couple things:

We copy vector<FieldT>'s around several times both outside and inside of libsnark's API. I'm unsure of how bulky this is (will check it out with massif) but this is definitely low hanging fruit for us. (In addition, we should use the libsnark API to reduce memory usage by throwing away objects we're no longer using like gadgets or the protoboard.)

@daira

This comment has been minimized.

Copy link
Contributor Author

@daira daira commented May 9, 2016

I'm very concerned that mitigating the attacks mentioned on #714 will increase the cost of proving to the point that we have to do some of the performance enhancements we've talked about (#896, this ticket, #647) before launch.

@daira daira modified the milestones: 1.0.1 stabilization, 1.1 Wishlist Sep 29, 2016
@zookozcash

This comment has been minimized.

Copy link

@zookozcash zookozcash commented Apr 2, 2017

@daira: What does it take to close this ticket? Do we need to close the 4 sub-tickets?

@daira

This comment has been minimized.

Copy link
Contributor Author

@daira daira commented Apr 3, 2017

This is an umbrella ticket, it's for keeping track of the subtickets that affect memory usage of proving and discussing how they interact, or brainstorming new ideas (like @ebfull's comment about vector<FieldT>s for example). It can be closed when we decide that's no longer useful.

@str4d str4d removed this from the Wishlist - Soon After 1.0.[Soon] milestone May 25, 2017
@daira daira added this to In Progress in Continuous Improvement Jun 7, 2017
@daira daira mentioned this issue Jun 26, 2019
zkbot added a commit that referenced this issue Aug 12, 2019
Remove libsnark

To-do:

- [x] Fix RPC tests.
- [ ] Remove now-dead codepaths.
- [ ] Add notable changes.

Closes #743. Closes #750. Closes #894. Closes #903.
Closes #1125. Closes #1136. Closes #1240. Closes #1264.
Closes #1516. Closes #1517. Closes #1651. Closes #2064.
Closes #2158. Closes #3478. Closes #3652. Closes #3744.
zkbot added a commit that referenced this issue Aug 12, 2019
Remove libsnark

To-do:

- [x] Fix RPC tests.
- [ ] Remove now-dead codepaths.
- [ ] Add notable changes.

Closes #743. Closes #750. Closes #894. Closes #903.
Closes #1125. Closes #1136. Closes #1240. Closes #1264.
Closes #1516. Closes #1517. Closes #1651. Closes #2064.
Closes #2158. Closes #3478. Closes #3652. Closes #3744.
zkbot added a commit that referenced this issue Aug 22, 2019
Remove libsnark

To-do:

- [x] Fix RPC tests.
- [ ] Remove now-dead codepaths.
- [ ] Add notable changes.

Closes #521.
Closes #743. Closes #750. Closes #894. Closes #903.
Closes #1125. Closes #1136. Closes #1240. Closes #1264.
Closes #1516. Closes #1517. Closes #1651. Closes #2064.
Closes #2158. Closes #3478. Closes #3652. Closes #3744.
zkbot added a commit that referenced this issue Aug 22, 2019
Remove libsnark

To-do:

- [x] Fix RPC tests.
- [ ] Remove now-dead codepaths.
- [ ] Add notable changes.

Closes #521.
Closes #743. Closes #750. Closes #894. Closes #903.
Closes #1125. Closes #1136. Closes #1240. Closes #1264.
Closes #1516. Closes #1517. Closes #1651. Closes #2064.
Closes #2158. Closes #3478. Closes #3652. Closes #3744.
@zkbot zkbot closed this in 961c0d5 Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Continuous Improvement
  
In Progress
4 participants
You can’t perform that action at this time.