Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUnwind #1144 txid malleability #1316
Conversation
bitcartel
added
review needed
needs prioritization
labels
Aug 27, 2016
bitcartel
added this to the
Beta 1 - complete RPC, audit mitigations, other linux support, user bugfixes milestone
Aug 27, 2016
added a commit
to bitcartel/zcash
that referenced
this pull request
Aug 28, 2016
This comment has been minimized.
This comment has been minimized.
|
ACK on diff review; I didn't do test coverage review. Also, I haven't decided if we do want to roll this back; I'm still learning about the security findings. |
nathan-at-least
referenced this pull request
Aug 29, 2016
Closed
ZCA-003 - scriptSig malleability allows 51% attack by invalidating honest miners blocks #1304
This comment has been minimized.
This comment has been minimized.
|
We've decided to merge this for Beta 1 and roll back this feature. |
nathan-at-least
removed
engineering meeting agenda
labels
Aug 29, 2016
This comment has been minimized.
This comment has been minimized.
|
I want us to get rid of the |
This comment has been minimized.
This comment has been minimized.
|
@ebfull I can add a commit to refactor GetTxid() calls as GetHash() and then remove that method completely. Is that ok? |
This comment has been minimized.
This comment has been minimized.
|
@bitcartel That would be fine with me! :) |
This comment has been minimized.
This comment has been minimized.
|
Note that the source tree will contain three references to a method getTxID() used by the QT gui. The capitalization is different from the method we removed. |
This comment has been minimized.
This comment has been minimized.
|
We're gonna wait until the last second to merge this that way our work on |
bitcartel
referenced this pull request
Sep 5, 2016
Closed
Document how non-malleable txids are generated so third parties can create them too. #1171
This comment has been minimized.
This comment has been minimized.
|
utACK+cov. |
This comment has been minimized.
This comment has been minimized.
|
@zkbot r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
pushed a commit
that referenced
this pull request
Sep 7, 2016
This comment has been minimized.
This comment has been minimized.
|
|
bitcartel
added some commits
Aug 27, 2016
bitcartel
force-pushed the
bitcartel:zc.v0.11.2.z9_unwind_1144
branch
from
131f020
to
fa511e1
Sep 7, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks! @zkbot r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
bitcartel commentedAug 27, 2016
This PR unwinds #1144, retaining GetTxid() as an alias for GetHash() to avoid having to rename across many files and any code in progress.
The txid gtest has been updated to verify that GetTxid() returns the same result as GetHash().
Both zcash-gtest and test_bitcoin pass.
Reviewers: It's easiest to review the 5 commits in chronological order. Each commit is quite small. Test files that have been rolled back (bloom_tests, script_invalid, script_valid) appear to be a big change, so it's easier to diff against the commit mentioned in the log.