New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CheckTransaction bugs. #1341

Merged
merged 2 commits into from Sep 7, 2016

Conversation

Projects
None yet
3 participants
@ebfull
Copy link
Contributor

ebfull commented Sep 5, 2016

Closes #1319.

Does not address the name of vpub_old or vpub_new.

@ebfull ebfull added the review needed label Sep 5, 2016

@ebfull ebfull modified the milestone: Beta 1 - complete RPC Sep 5, 2016

@daira

This comment has been minimized.

Copy link
Contributor

daira commented Sep 7, 2016

utACK+cov.

@ebfull

This comment has been minimized.

Copy link
Contributor Author

ebfull commented Sep 7, 2016

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 7, 2016

📌 Commit d7eeb74 has been approved by ebfull

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 7, 2016

⌛️ Testing commit d7eeb74 with merge 0d91946...

zkbot pushed a commit that referenced this pull request Sep 7, 2016

zkbot
Auto merge of #1341 - ebfull:fix-checktransaction-bug, r=ebfull
Fix CheckTransaction bugs.

Closes #1319.

Does not address the name of `vpub_old` or `vpub_new`.
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 7, 2016

💔 Test failed - zcash

@ebfull

This comment has been minimized.

Copy link
Contributor Author

ebfull commented Sep 7, 2016

One of the old test_bitcoin tests wasn't changed.

@zkbot r+ a4b0037

zkbot pushed a commit that referenced this pull request Sep 7, 2016

zkbot
Auto merge of #1341 - ebfull:fix-checktransaction-bug, r=ebfull
Fix CheckTransaction bugs.

Closes #1319.

Does not address the name of `vpub_old` or `vpub_new`.
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 7, 2016

⌛️ Testing commit a4b0037 with merge 02932fc...

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 7, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit a4b0037 into zcash:zc.v0.11.2.latest Sep 7, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment