Add node metrics screen #1375

str4d · 2016-09-10T11:42:24Z

Continuation of #1336
Closes #1331

str4d · 2016-10-05T23:46:51Z

I have rebased this PR on beta 2.

zkbot · 2016-10-21T23:46:31Z

☔ The latest upstream changes (presumably #1578) made this pull request unmergeable. Please resolve the merge conflicts.

daira · 2016-10-22T19:11:34Z

I rebased this on current master (post-#1578).

daira · 2016-10-22T19:22:34Z

src/rpcmining.cpp

@@ -191,15 +192,20 @@ Value generate(const Array& params, bool fHelp)
            std::function<bool(std::vector<unsigned char>)> validBlock =
                    [&pblock](std::vector<unsigned char> soln) {
                pblock->nSolution = soln;
+                solutionTargetChecks.increment();


This RPC method is only used for regtest, so it doesn't need any of the increment() calls. Does not block (these calls are harmless, just unnecessary).

daira · 2016-10-22T19:24:09Z

utACK.

str4d · 2016-10-22T20:26:07Z

utACK, looks like @daira added the extra count calls for tromp's solver.

Note that the print statements in tromp's solver will interfere with the metrics screen output. I'll test it now and see if I'd need to fix it (which i can do now).

daira · 2016-10-22T20:30:01Z

It's fine to just comment out those print statements, I think.

str4d · 2016-10-22T20:30:37Z

Yeah, that's what I'll do for now.

str4d · 2016-10-22T20:47:10Z

Okay, it interferes with one of the auto-update lines, but doesn't obscure any information and doesn't break the UI. Still, I'll fix it now :)

The screen is implemented using ANSI Escape sequences. Closes zcash#1331

Part of zcash#1422

str4d · 2016-10-22T20:51:08Z

Found a bug: the solver increment call for tromp's solver was added inside the solution for loop, so it is counting every found solution instead of every run. Rebasing on master to fix.

daira · 2016-10-22T20:58:06Z

Oops, should have checked that more carefully.

daira · 2016-10-22T21:14:51Z

re-utACK. (I checked the fix for the bug @str4d mentioned, and the last commit commenting out printfs.)

str4d · 2016-10-22T21:50:46Z

Assigning to @nathan-at-least for a decision, because @zookozcash really really really wants this merged, particularly as we also merged #1578 to include a faster miner (although that is not enabled by default, but everyone is going to use it anyway).

daira · 2016-10-22T22:10:43Z

@nathan-at-least said:

I won't have time today, most likely. I'm comfortable with you deciding. If it still needs my input on Monday I'll look at it early.

My decision is yes, provided it merges and tests cleanly now. @zkbot r+

zkbot · 2016-10-22T22:10:44Z

📌 Commit dccc140 has been approved by daira

zkbot · 2016-10-22T22:10:46Z

⌛ Testing commit dccc140 with merge 5562f8d...

Add node metrics screen Continuation of #1336 Closes #1331

zkbot · 2016-10-22T23:30:22Z

💔 Test failed - zcash

str4d · 2016-10-22T23:36:35Z

@daira:

My decision is yes, provided it merges and tests cleanly now.

I just pushed the one-line fix to get the RPC tests running. Should I re-run?

str4d · 2016-10-22T23:41:38Z

Gonna re-run

@zkbot r+

zkbot · 2016-10-22T23:41:38Z

📌 Commit d6feeef has been approved by str4d

zkbot · 2016-10-22T23:41:41Z

⌛ Testing commit d6feeef with merge a884e5f...

Add node metrics screen Continuation of #1336 Closes #1331

daira · 2016-10-22T23:54:46Z

@zkbot cancel

Author: Jack Grigg <jack@z.cash> Signed-off-by: Daira Hopwood <daira@jacaranda.org>

daira · 2016-10-23T00:07:30Z

Please don't r+ until I've checked something locally. (I want to check how the metrics screen interacts with -printtoconsole.)

daira · 2016-10-23T00:13:44Z

OK, showmetrics is disabled when printtoconsole is enabled. Just doing a smoke test...

daira · 2016-10-23T00:19:59Z

Smoke-tested ACK. @zkbot r+

zkbot · 2016-10-23T00:19:59Z

📌 Commit 02a4ace has been approved by daira

zkbot · 2016-10-23T00:20:05Z

⌛ Testing commit 02a4ace with merge a294b26...

Add node metrics screen Continuation of #1336 Closes #1331

zkbot · 2016-10-23T01:01:45Z

☀️ Test successful - zcash

str4d added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. special to Zooko usability engineering meeting agenda labels Sep 10, 2016

nathan-at-least added this to the 1.0.1 stabilization milestone Sep 12, 2016

nathan-at-least removed the engineering meeting agenda label Sep 12, 2016

str4d mentioned this pull request Sep 20, 2016

Update documentation to refer to a "solution rate" for mining #1422

Closed

str4d force-pushed the 1331-node-metrics branch from 7617dc3 to 90b9f99 Compare October 5, 2016 23:45

daira force-pushed the 1331-node-metrics branch from 90b9f99 to 5c60ee7 Compare October 22, 2016 19:10

daira reviewed Oct 22, 2016

View changes

str4d added 10 commits October 22, 2016 15:50

Add a persistent screen showing basic node metrics

a6df7ab

The screen is implemented using ANSI Escape sequences. Closes zcash#1331

Show important console messages on metrics screen

4ace963

Fit metrics screen into an 80-column terminal without wrapping

d934e68

Adjust copy

4482bd8

Split out screen sections into separate functions

d30273f

Tag metrics strings for translation

0ddd6d1

Handle wrapping of potentially long lines

db853f8

Add average hash rate to metrics

e7d59bb

Be excited about validating transactions!

f8ada24

Use solutions per second (Sol/s)

199b3aa

Part of zcash#1422

str4d assigned nathan-at-least Oct 22, 2016

zkbot pushed a commit that referenced this pull request Oct 22, 2016

Auto merge of #1375 - str4d:1331-node-metrics, r=daira

5562f8d

Add node metrics screen Continuation of #1336 Closes #1331

daira modified the milestones: 1.0.0-rc2, 1.0.1 stabilization Oct 22, 2016

zkbot pushed a commit that referenced this pull request Oct 22, 2016

Auto merge of #1375 - str4d:1331-node-metrics, r=str4d

a884e5f

Add node metrics screen Continuation of #1336 Closes #1331

Disable metrics screen in RPC tests

02a4ace

Author: Jack Grigg <jack@z.cash> Signed-off-by: Daira Hopwood <daira@jacaranda.org>

daira force-pushed the 1331-node-metrics branch from d6feeef to 02a4ace Compare October 23, 2016 00:06

daira assigned daira and unassigned nathan-at-least Oct 23, 2016

zkbot pushed a commit that referenced this pull request Oct 23, 2016

Auto merge of #1375 - str4d:1331-node-metrics, r=daira

a294b26

Add node metrics screen Continuation of #1336 Closes #1331

zkbot merged commit 02a4ace into zcash:master Oct 23, 2016

str4d deleted the 1331-node-metrics branch October 23, 2016 04:11

ageis mentioned this pull request Oct 23, 2016

systemd doesn't play nice with showmetrics #1612

Closed

Add node metrics screen #1375

Add node metrics screen #1375

str4d commented Sep 10, 2016

str4d commented Oct 5, 2016

zkbot commented Oct 21, 2016

daira commented Oct 22, 2016

daira Oct 22, 2016 •

edited

daira commented Oct 22, 2016

str4d commented Oct 22, 2016

daira commented Oct 22, 2016

str4d commented Oct 22, 2016

str4d commented Oct 22, 2016

str4d commented Oct 22, 2016

daira commented Oct 22, 2016

daira commented Oct 22, 2016 •

edited

str4d commented Oct 22, 2016

daira commented Oct 22, 2016

zkbot commented Oct 22, 2016

zkbot commented Oct 22, 2016

zkbot commented Oct 22, 2016

str4d commented Oct 22, 2016

str4d commented Oct 22, 2016

zkbot commented Oct 22, 2016

zkbot commented Oct 22, 2016

daira commented Oct 22, 2016

daira commented Oct 23, 2016 •

edited

daira commented Oct 23, 2016

daira commented Oct 23, 2016

zkbot commented Oct 23, 2016

zkbot commented Oct 23, 2016

zkbot commented Oct 23, 2016

Add node metrics screen #1375

Add node metrics screen #1375

Conversation

str4d commented Sep 10, 2016

str4d commented Oct 5, 2016

zkbot commented Oct 21, 2016

daira commented Oct 22, 2016

daira Oct 22, 2016 • edited

Choose a reason for hiding this comment

daira commented Oct 22, 2016

str4d commented Oct 22, 2016

daira commented Oct 22, 2016

str4d commented Oct 22, 2016

str4d commented Oct 22, 2016

str4d commented Oct 22, 2016

daira commented Oct 22, 2016

daira commented Oct 22, 2016 • edited

str4d commented Oct 22, 2016

daira commented Oct 22, 2016

zkbot commented Oct 22, 2016

zkbot commented Oct 22, 2016

zkbot commented Oct 22, 2016

str4d commented Oct 22, 2016

str4d commented Oct 22, 2016

zkbot commented Oct 22, 2016

zkbot commented Oct 22, 2016

daira commented Oct 22, 2016

daira commented Oct 23, 2016 • edited

daira commented Oct 23, 2016

daira commented Oct 23, 2016

zkbot commented Oct 23, 2016

zkbot commented Oct 23, 2016

zkbot commented Oct 23, 2016

daira Oct 22, 2016 •

edited

daira commented Oct 22, 2016 •

edited

daira commented Oct 23, 2016 •

edited