Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Integrating tromp solvers into miner #1570
Integrated tromp equihash algorithm for mining.
Forum thread: https://forum.z.cash/t/tromps-solvers/2465/197
Able to generate multiple blocks on testnet.
By default this solver is disabled. Need to add macro declaration to enable this solver.
How to enable tromp equihash solver:
Rebuild and run your zcshd.
Able to generate multiple blocks on testnet. https://explorer.testnet.z.cash/block/000a8464db4d2e6ab597acdda0237641ac0baa4e4cd629a02fa47b06fa31a2079 Integrating tromp's memory optimizations Adding macro control to enable tromp solver Original solvers are available in https://github.com/tromp/equihash How to enable tromp equihash solver: In miner.cpp uncomment following line(35th line). // #define USE_TROMP_EQUIHASH Rebuild and run your zcshd. Performance: Single thread, on 4core, 8GB RAM machine, getting 1 Sol/s.
Firstly, I've built this, it works (I mined several blocks), and it feels ridiculous (compared to my implementation). Thanks for integrating it @sarath-hotspot!
I discussed this with @nathan-at-least, and we're very keen to get this merged in before launch, as well as any other solvers that are available and can be integrated. One of our desired goals is for mining to be decentralised, and having several different solvers built into
(And yet another disclaimer: merging of this PR, or of any solvers submitted to the Miner Challenge, into
The primary issue now is getting this done in time for RC 2, which looks to be the last code merge point before launch. I'm going to review this PR now, but there is definitely some work that needs to be done before we merge it. @sarath-hotspot, will you have time to work on this PR over the next 30 or so hours? Comments will need to be addressed by the end of Thursday US if we are to merge this PR on Friday. If you don't have time, that's fine - let me know, and I can do the remaining integration work myself. But as the OP, it would be fantastic to have your contributions directly merged
Please let me know your comments. I could squeeze 3-4 hours from my work
On Oct 20, 2016 1:02 AM, "str4d" firstname.lastname@example.org wrote:
str4d left a comment
Good start! In addition to my specific comments, I'd like to see the commits refactored so that the first commit is a direct import of @tromp's mining code, as verbatim as possible, with the license and a link to the exact commit the code is taken from in the commit message (see this commit in my standalone miner for an example). This will make importing future updates much easier.
The impact of the blake change may be less than that of the speed