New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream: Prevent possible DoS in logging #1588

Merged
merged 2 commits into from Oct 22, 2016

Conversation

Projects
None yet
4 participants
@bitcartel
Contributor

bitcartel commented Oct 21, 2016

@bitcartel bitcartel added this to the 1.0.0-rc2 milestone Oct 21, 2016

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Oct 21, 2016

Contributor

Ping @daira - there are a bunch of DoS related pull requests (Electric-Coin-Company/zecc-private#30 (comment)) tagged for rc2 and ready for review.

Contributor

bitcartel commented Oct 21, 2016

Ping @daira - there are a bunch of DoS related pull requests (Electric-Coin-Company/zecc-private#30 (comment)) tagged for rc2 and ready for review.

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Oct 22, 2016

Contributor

ACK, matches upstream PR (modulo whitespace). @zkbot r+

Contributor

daira commented Oct 22, 2016

ACK, matches upstream PR (modulo whitespace). @zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

📌 Commit e496b2e has been approved by daira

Contributor

zkbot commented Oct 22, 2016

📌 Commit e496b2e has been approved by daira

zkbot pushed a commit that referenced this pull request Oct 22, 2016

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

⌛️ Testing commit e496b2e with merge efc7718...

Contributor

zkbot commented Oct 22, 2016

⌛️ Testing commit e496b2e with merge efc7718...

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

💔 Test failed - zcash

Contributor

zkbot commented Oct 22, 2016

💔 Test failed - zcash

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Oct 22, 2016

Contributor

@daira Fixed. Ready for zkbot.

Contributor

bitcartel commented Oct 22, 2016

@daira Fixed. Ready for zkbot.

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Oct 22, 2016

Contributor

ACK. @zkbot r+

Contributor

daira commented Oct 22, 2016

ACK. @zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

📌 Commit 432bc22 has been approved by daira

Contributor

zkbot commented Oct 22, 2016

📌 Commit 432bc22 has been approved by daira

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

⌛️ Testing commit 432bc22 with merge e3c8e88...

Contributor

zkbot commented Oct 22, 2016

⌛️ Testing commit 432bc22 with merge e3c8e88...

zkbot pushed a commit that referenced this pull request Oct 22, 2016

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

☀️ Test successful - zcash

Contributor

zkbot commented Oct 22, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 432bc22 into zcash:master Oct 22, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment