Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream: Prevent possible DoS in logging #1588

Merged
merged 2 commits into from Oct 22, 2016

Conversation

@bitcartel
Copy link
Contributor

@bitcartel bitcartel commented Oct 21, 2016

@bitcartel bitcartel added this to the 1.0.0-rc2 milestone Oct 21, 2016
@bitcartel
Copy link
Contributor Author

@bitcartel bitcartel commented Oct 21, 2016

Ping @daira - there are a bunch of DoS related pull requests (https://github.com/Electric-Coin-Company/zecc-private/issues/30#issuecomment-244238679) tagged for rc2 and ready for review.

@daira
Copy link
Contributor

@daira daira commented Oct 22, 2016

ACK, matches upstream PR (modulo whitespace). @zkbot r+

@zkbot
Copy link
Collaborator

@zkbot zkbot commented Oct 22, 2016

📌 Commit e496b2e has been approved by daira

zkbot pushed a commit that referenced this pull request Oct 22, 2016
@zkbot
Copy link
Collaborator

@zkbot zkbot commented Oct 22, 2016

Testing commit e496b2e with merge efc7718...

@zkbot
Copy link
Collaborator

@zkbot zkbot commented Oct 22, 2016

💔 Test failed - zcash

@bitcartel
Copy link
Contributor Author

@bitcartel bitcartel commented Oct 22, 2016

@daira Fixed. Ready for zkbot.

@daira
Copy link
Contributor

@daira daira commented Oct 22, 2016

ACK. @zkbot r+

@zkbot
Copy link
Collaborator

@zkbot zkbot commented Oct 22, 2016

📌 Commit 432bc22 has been approved by daira

@zkbot
Copy link
Collaborator

@zkbot zkbot commented Oct 22, 2016

Testing commit 432bc22 with merge e3c8e88...

zkbot pushed a commit that referenced this pull request Oct 22, 2016
@bitcartel bitcartel added I-dos and removed S-waiting-on-review labels Oct 22, 2016
@zkbot
Copy link
Collaborator

@zkbot zkbot commented Oct 22, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 432bc22 into zcash:master Oct 22, 2016
1 check passed
1 check passed
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.