New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream: Only send one GetAddr response per connection. #1589

Merged
merged 1 commit into from Oct 22, 2016

Conversation

Projects
None yet
4 participants
@bitcartel
Contributor

bitcartel commented Oct 21, 2016

Only send one GetAddr response per connection.
This conserves resources from abusive peers that just send
 getaddr in a loop. Also makes correlating addr messages
 against INVs less effective.
@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Oct 22, 2016

Contributor

bitcoin/bitcoin#8427 is a different PR. I think you mean bitcoin/bitcoin#7856

Contributor

daira commented Oct 22, 2016

bitcoin/bitcoin#8427 is a different PR. I think you mean bitcoin/bitcoin#7856

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Oct 22, 2016

Contributor

ACK, matches upstream PR (bitcoin/bitcoin#7856 that is). @zkbot r+

Contributor

daira commented Oct 22, 2016

ACK, matches upstream PR (bitcoin/bitcoin#7856 that is). @zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

📌 Commit a514cb2 has been approved by daira

Contributor

zkbot commented Oct 22, 2016

📌 Commit a514cb2 has been approved by daira

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

📌 Commit a514cb2 has been approved by daira

Contributor

zkbot commented Oct 22, 2016

📌 Commit a514cb2 has been approved by daira

zkbot pushed a commit that referenced this pull request Oct 22, 2016

zkbot
Auto merge of #1589 - bitcartel:upstream_7856_one_getaddr_per_connect…
…ion, r=daira

Upstream: Only send one GetAddr response per connection.

bitcoin/bitcoin#8427
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

⌛️ Testing commit a514cb2 with merge f808be7...

Contributor

zkbot commented Oct 22, 2016

⌛️ Testing commit a514cb2 with merge f808be7...

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 22, 2016

Contributor

☀️ Test successful - zcash

Contributor

zkbot commented Oct 22, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit a514cb2 into zcash:master Oct 22, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment