GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw more descriptive exceptions when the constraint system is viola…
This is ready for review! :)
input note value too big (greater than MAX_MONEY) would be more descriptive than nonsensical.
utACK modulo comment.
Is this (and subsequent changes in this file) for fixing issues that are now properly caught? If so, nice!
input value too big (greater than MAX_MONEY)
Ditto above, I prefer referring to MAX_MONEY rather than just say nonsensical.
vpub_old is invalid / too big, greater than MAX_MONEY
How about MAX_MONEY + 1 ?
vpub_old value is too big, > MAX_MONEY
MAX_MONEY + 1
ACK but see comments (which are none blocking)
posted on wrong pr
📌 Commit c4643bd has been approved by ebfull
⌛️ Testing commit c4643bd with merge 624b5f3...
Auto merge of #1752 - ebfull:diagnostics-of-constraint-system-violati…
Throw more descriptive exceptions when the constraint system is violated
☀️ Test successful - zcash
[commented on wrong PR]