Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build scripts and fetch-params.sh to "make install" and "make dist" #1758

Merged
merged 1 commit into from Nov 3, 2016

Conversation

@str4d
Copy link
Contributor

str4d commented Nov 2, 2016

Closes #1728

@str4d
Copy link
Contributor Author

str4d commented Nov 2, 2016

I'm running a Gitian build on this branch to check that it resolves #1728.

@str4d str4d force-pushed the str4d:1728-install-and-dist-scripts branch from da822e5 to 0fb11ee Nov 2, 2016
@str4d
Copy link
Contributor Author

str4d commented Nov 2, 2016

Rebased to add a missing \.

Closes #1728
@str4d str4d force-pushed the str4d:1728-install-and-dist-scripts branch from 0fb11ee to 33efd81 Nov 2, 2016
@str4d
Copy link
Contributor Author

str4d commented Nov 2, 2016

Rebased to fix Makefile (and simplify) by always installing fetch-params.sh regardless of build flags.

@str4d
Copy link
Contributor Author

str4d commented Nov 2, 2016

I've run a Gitian build on 33efd81 and confirmed that zcutil/fetch-params.sh appears in zcash-1.0.0.tar.gz, and that bin/zcash-fetch-params appears in zcash-1.0.0-linux64.tar.gz. bin/zcash-fetch-params does not appear in zcash-1.0.0-linux64-debug.tar.gz, but that is fine, because the debug binary tarball is intended for use in tandem with the regular binary tarball.

@ageis
Copy link
Contributor

ageis commented Nov 2, 2016

Partial ACK. Thanks for taking care of this! @str4d, another refinement that we should make is to make it so that build-debian-package.sh works with the paths of the binaries extracted from the Gitian release tarball. Presently, I have to extract the Gitian release tarball and move binaries into /src (as if I was building Zcash in a regular source tree) for the Debian package script to work.

@ebfull
Copy link
Contributor

ebfull commented Nov 2, 2016

utACK

@str4d
Copy link
Contributor Author

str4d commented Nov 2, 2016

@ageis

another refinement that we should make is to make it so that build-debian-package.sh works with the paths of the binaries extracted from the Gitian release tarball. Presently, I have to extract the Gitian release tarball and move binaries into /src (as if I was building Zcash in a regular source tree) for the Debian package script to work.

ACK, but I wouldn't block this PR on that. We don't currently include the Debian build script in the binary package, and this PR only adds it into the source tarball.

@ageis
Copy link
Contributor

ageis commented Nov 2, 2016

Ok, then utACK.

@str4d
Copy link
Contributor Author

str4d commented Nov 3, 2016

@zkbot r+

@zkbot
Copy link
Collaborator

zkbot commented Nov 3, 2016

📌 Commit 33efd81 has been approved by str4d

@zkbot
Copy link
Collaborator

zkbot commented Nov 3, 2016

Testing commit 33efd81 with merge 5cdbf67...

zkbot pushed a commit that referenced this pull request Nov 3, 2016
Add build scripts and fetch-params.sh to "make install" and "make dist"

Closes #1728
@zkbot
Copy link
Collaborator

zkbot commented Nov 3, 2016

💔 Test failed - zcash

@ebfull
Copy link
Contributor

ebfull commented Nov 3, 2016

@zkbot retry

zkbot pushed a commit that referenced this pull request Nov 3, 2016
Add build scripts and fetch-params.sh to "make install" and "make dist"

Closes #1728
@zkbot
Copy link
Collaborator

zkbot commented Nov 3, 2016

Testing commit 33efd81 with merge f8b9383...

@zkbot
Copy link
Collaborator

zkbot commented Nov 3, 2016

💔 Test failed - zcash

@str4d
Copy link
Contributor Author

str4d commented Nov 3, 2016

@zkbot retry

@zkbot
Copy link
Collaborator

zkbot commented Nov 3, 2016

Testing commit 33efd81 with merge a2d8669...

zkbot pushed a commit that referenced this pull request Nov 3, 2016
Add build scripts and fetch-params.sh to "make install" and "make dist"

Closes #1728
@zkbot
Copy link
Collaborator

zkbot commented Nov 3, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 33efd81 into zcash:master Nov 3, 2016
1 check passed
1 check passed
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.