New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build scripts and fetch-params.sh to "make install" and "make dist" #1758

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
4 participants
@str4d
Contributor

str4d commented Nov 2, 2016

Closes #1728

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 2, 2016

Contributor

I'm running a Gitian build on this branch to check that it resolves #1728.

Contributor

str4d commented Nov 2, 2016

I'm running a Gitian build on this branch to check that it resolves #1728.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 2, 2016

Contributor

Rebased to add a missing \.

Contributor

str4d commented Nov 2, 2016

Rebased to add a missing \.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 2, 2016

Contributor

Rebased to fix Makefile (and simplify) by always installing fetch-params.sh regardless of build flags.

Contributor

str4d commented Nov 2, 2016

Rebased to fix Makefile (and simplify) by always installing fetch-params.sh regardless of build flags.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 2, 2016

Contributor

I've run a Gitian build on 33efd81 and confirmed that zcutil/fetch-params.sh appears in zcash-1.0.0.tar.gz, and that bin/zcash-fetch-params appears in zcash-1.0.0-linux64.tar.gz. bin/zcash-fetch-params does not appear in zcash-1.0.0-linux64-debug.tar.gz, but that is fine, because the debug binary tarball is intended for use in tandem with the regular binary tarball.

Contributor

str4d commented Nov 2, 2016

I've run a Gitian build on 33efd81 and confirmed that zcutil/fetch-params.sh appears in zcash-1.0.0.tar.gz, and that bin/zcash-fetch-params appears in zcash-1.0.0-linux64.tar.gz. bin/zcash-fetch-params does not appear in zcash-1.0.0-linux64-debug.tar.gz, but that is fine, because the debug binary tarball is intended for use in tandem with the regular binary tarball.

@ageis

This comment has been minimized.

Show comment
Hide comment
@ageis

ageis Nov 2, 2016

Contributor

Partial ACK. Thanks for taking care of this! @str4d, another refinement that we should make is to make it so that build-debian-package.sh works with the paths of the binaries extracted from the Gitian release tarball. Presently, I have to extract the Gitian release tarball and move binaries into /src (as if I was building Zcash in a regular source tree) for the Debian package script to work.

Contributor

ageis commented Nov 2, 2016

Partial ACK. Thanks for taking care of this! @str4d, another refinement that we should make is to make it so that build-debian-package.sh works with the paths of the binaries extracted from the Gitian release tarball. Presently, I have to extract the Gitian release tarball and move binaries into /src (as if I was building Zcash in a regular source tree) for the Debian package script to work.

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 2, 2016

Contributor

utACK

Contributor

ebfull commented Nov 2, 2016

utACK

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 2, 2016

Contributor

@ageis

another refinement that we should make is to make it so that build-debian-package.sh works with the paths of the binaries extracted from the Gitian release tarball. Presently, I have to extract the Gitian release tarball and move binaries into /src (as if I was building Zcash in a regular source tree) for the Debian package script to work.

ACK, but I wouldn't block this PR on that. We don't currently include the Debian build script in the binary package, and this PR only adds it into the source tarball.

Contributor

str4d commented Nov 2, 2016

@ageis

another refinement that we should make is to make it so that build-debian-package.sh works with the paths of the binaries extracted from the Gitian release tarball. Presently, I have to extract the Gitian release tarball and move binaries into /src (as if I was building Zcash in a regular source tree) for the Debian package script to work.

ACK, but I wouldn't block this PR on that. We don't currently include the Debian build script in the binary package, and this PR only adds it into the source tarball.

@ageis

This comment has been minimized.

Show comment
Hide comment
@ageis

ageis Nov 2, 2016

Contributor

Ok, then utACK.

Contributor

ageis commented Nov 2, 2016

Ok, then utACK.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 3, 2016

Contributor

@zkbot r+

Contributor

str4d commented Nov 3, 2016

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

📌 Commit 33efd81 has been approved by str4d

Contributor

zkbot commented Nov 3, 2016

📌 Commit 33efd81 has been approved by str4d

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

⌛️ Testing commit 33efd81 with merge 5cdbf67...

Contributor

zkbot commented Nov 3, 2016

⌛️ Testing commit 33efd81 with merge 5cdbf67...

zkbot pushed a commit that referenced this pull request Nov 3, 2016

zkbot
Auto merge of #1758 - str4d:1728-install-and-dist-scripts, r=str4d
Add build scripts and fetch-params.sh to "make install" and "make dist"

Closes #1728
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

💔 Test failed - zcash

Contributor

zkbot commented Nov 3, 2016

💔 Test failed - zcash

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 3, 2016

Contributor

@zkbot retry

Contributor

ebfull commented Nov 3, 2016

@zkbot retry

zkbot pushed a commit that referenced this pull request Nov 3, 2016

zkbot
Auto merge of #1758 - str4d:1728-install-and-dist-scripts, r=str4d
Add build scripts and fetch-params.sh to "make install" and "make dist"

Closes #1728
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

⌛️ Testing commit 33efd81 with merge f8b9383...

Contributor

zkbot commented Nov 3, 2016

⌛️ Testing commit 33efd81 with merge f8b9383...

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

💔 Test failed - zcash

Contributor

zkbot commented Nov 3, 2016

💔 Test failed - zcash

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 3, 2016

Contributor

@zkbot retry

Contributor

str4d commented Nov 3, 2016

@zkbot retry

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

⌛️ Testing commit 33efd81 with merge a2d8669...

Contributor

zkbot commented Nov 3, 2016

⌛️ Testing commit 33efd81 with merge a2d8669...

zkbot pushed a commit that referenced this pull request Nov 3, 2016

zkbot
Auto merge of #1758 - str4d:1728-install-and-dist-scripts, r=str4d
Add build scripts and fetch-params.sh to "make install" and "make dist"

Closes #1728
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

☀️ Test successful - zcash

Contributor

zkbot commented Nov 3, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 33efd81 into zcash:master Nov 3, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment