Track the correct change witness across chained joinsplits when notes are shuffled #1814

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
4 participants
@bitcartel
Contributor

bitcartel commented Nov 7, 2016

@bitcartel bitcartel added this to the 1.0.3 milestone Nov 11, 2016

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Nov 11, 2016

Contributor

@daira This PR is for #1819

Contributor

bitcartel commented Nov 11, 2016

@daira This PR is for #1819

@bitcartel bitcartel changed the title from [WIP] Track the correct change witness across chained joinsplits when notes are shuffled to Track the correct change witness across chained joinsplits when notes are shuffled Nov 11, 2016

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 13, 2016

Contributor

ACK I helped @bitcartel work through this.

I really think this code needs to be refactored eventually with some kind of transaction builder abstraction.

Contributor

ebfull commented Nov 13, 2016

ACK I helped @bitcartel work through this.

I really think this code needs to be refactored eventually with some kind of transaction builder abstraction.

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 15, 2016

Contributor

This can be r+'d anytime @bitcartel, but can you check that GenIdentity is not made stale code by this PR? I can't remember.

Contributor

ebfull commented Nov 15, 2016

This can be r+'d anytime @bitcartel, but can you check that GenIdentity is not made stale code by this PR? I can't remember.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 15, 2016

Contributor

utACK. Nice work @bitcartel and @ebfull!

Contributor

str4d commented Nov 15, 2016

utACK. Nice work @bitcartel and @ebfull!

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Nov 15, 2016

Contributor

@ebfull GenIdentity is still used in gtest/test_random.cpp.

I'm not going to r+ this just yet, want to run more tests.

Contributor

bitcartel commented Nov 15, 2016

@ebfull GenIdentity is still used in gtest/test_random.cpp.

I'm not going to r+ this just yet, want to run more tests.

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Nov 15, 2016

Contributor

Rebased on master.

@zkbot r+

Contributor

bitcartel commented Nov 15, 2016

Rebased on master.

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

📌 Commit de38bfb has been approved by bitcartel

Contributor

zkbot commented Nov 15, 2016

📌 Commit de38bfb has been approved by bitcartel

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

⌛️ Testing commit de38bfb with merge de38bfb...

Contributor

zkbot commented Nov 15, 2016

⌛️ Testing commit de38bfb with merge de38bfb...

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
Contributor

zkbot commented Nov 15, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

📌 Commit de38bfb has been approved by bitcartel

Contributor

zkbot commented Nov 15, 2016

📌 Commit de38bfb has been approved by bitcartel

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

☀️ Test successful - zcash

Contributor

zkbot commented Nov 15, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit de38bfb into zcash:master Nov 15, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment