Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the correct change witness across chained joinsplits when notes are shuffled #1814

Merged

Conversation

@bitcartel
Copy link
Contributor

bitcartel commented Nov 7, 2016

@bitcartel bitcartel force-pushed the bitcartel:master_shuffling_change_witness_zsendmany branch from fac168a to 477424d Nov 10, 2016
@bitcartel bitcartel added this to the 1.0.3 milestone Nov 11, 2016
@bitcartel
Copy link
Contributor Author

bitcartel commented Nov 11, 2016

@daira This PR is for #1819

@bitcartel bitcartel changed the title [WIP] Track the correct change witness across chained joinsplits when notes are shuffled Track the correct change witness across chained joinsplits when notes are shuffled Nov 11, 2016
@ebfull
Copy link
Contributor

ebfull commented Nov 13, 2016

ACK I helped @bitcartel work through this.

I really think this code needs to be refactored eventually with some kind of transaction builder abstraction.

@ebfull
Copy link
Contributor

ebfull commented Nov 15, 2016

This can be r+'d anytime @bitcartel, but can you check that GenIdentity is not made stale code by this PR? I can't remember.

@str4d
Copy link
Contributor

str4d commented Nov 15, 2016

utACK. Nice work @bitcartel and @ebfull!

@bitcartel
Copy link
Contributor Author

bitcartel commented Nov 15, 2016

@ebfull GenIdentity is still used in gtest/test_random.cpp.

I'm not going to r+ this just yet, want to run more tests.

@bitcartel bitcartel force-pushed the bitcartel:master_shuffling_change_witness_zsendmany branch from 477424d to de38bfb Nov 15, 2016
@bitcartel
Copy link
Contributor Author

bitcartel commented Nov 15, 2016

Rebased on master.

@zkbot r+

@zkbot
Copy link
Collaborator

zkbot commented Nov 15, 2016

📌 Commit de38bfb has been approved by bitcartel

@zkbot
Copy link
Collaborator

zkbot commented Nov 15, 2016

Testing commit de38bfb with merge de38bfb...

@zkbot
Copy link
Collaborator

zkbot commented Nov 15, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@zkbot
Copy link
Collaborator

zkbot commented Nov 15, 2016

📌 Commit de38bfb has been approved by bitcartel

@zkbot
Copy link
Collaborator

zkbot commented Nov 15, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit de38bfb into zcash:master Nov 15, 2016
1 check passed
1 check passed
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.