Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1680, temporary fix for rpc deadlock inherited from upstream. #1847

Merged
merged 1 commit into from Nov 15, 2016

Conversation

bitcartel
Copy link
Contributor

@bitcartel bitcartel commented Nov 11, 2016

No description provided.

@bitcartel bitcartel added S-waiting-on-review A-rpc-interface A-wallet usability labels Nov 11, 2016
@bitcartel bitcartel added this to the 1.0.3 milestone Nov 12, 2016
@ebfull
Copy link
Contributor

@ebfull ebfull commented Nov 13, 2016

Let's have a ticket regarding re-enabling this (and other things mentioned in the comments) and reference the ticket from the comments in this PR.

@bitcartel
Copy link
Contributor Author

@bitcartel bitcartel commented Nov 14, 2016

@ebfull Added ticket #1856 to comments. Please review and ACK.

@ebfull
Copy link
Contributor

@ebfull ebfull commented Nov 15, 2016

ACK

@zkbot r+

@zkbot
Copy link
Contributor

@zkbot zkbot commented Nov 15, 2016

📌 Commit fd0fe09 has been approved by ebfull

zkbot pushed a commit that referenced this issue Nov 15, 2016
Closes #1680, temporary fix for rpc deadlock inherited from upstream.
@zkbot
Copy link
Contributor

@zkbot zkbot commented Nov 15, 2016

Testing commit fd0fe09 with merge f9970fa...

@zkbot
Copy link
Contributor

@zkbot zkbot commented Nov 15, 2016

💔 Test failed - zcash

@str4d
Copy link
Contributor

@str4d str4d commented Nov 15, 2016

@bitcartel per the test failure, the RPC test httpbasics.py needs updating.

@bitcartel bitcartel force-pushed the 1680_rpckeepalive_deadlock branch from fd0fe09 to f4404d7 Compare Nov 15, 2016
@bitcartel
Copy link
Contributor Author

@bitcartel bitcartel commented Nov 15, 2016

@zkbot retry

@ebfull
Copy link
Contributor

@ebfull ebfull commented Nov 15, 2016

@zkbot r+

@zkbot
Copy link
Contributor

@zkbot zkbot commented Nov 15, 2016

📌 Commit f4404d7 has been approved by ebfull

@zkbot
Copy link
Contributor

@zkbot zkbot commented Nov 15, 2016

Testing commit f4404d7 with merge 4e72614...

zkbot pushed a commit that referenced this issue Nov 15, 2016
Closes #1680, temporary fix for rpc deadlock inherited from upstream.
@zkbot
Copy link
Contributor

@zkbot zkbot commented Nov 15, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit f4404d7 into zcash:master Nov 15, 2016
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc-interface A-wallet S-waiting-on-review usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants