Adjust fees to that z_sendmany tx using default built-in fee are not rejected by nodes #1855

Merged
merged 2 commits into from Nov 15, 2016

Conversation

Projects
None yet
4 participants
@bitcartel
Contributor

bitcartel commented Nov 14, 2016

Resolves #1719 by setting min relay tx fee to 1000 to match upstream (they were experimenting wtih 5000 when zcash forked from upstream).

Temporary resolution for #1851 so that z_sendmany with thousands of taddr recipients will be accepted and not rejected because of insufficient fee. Users are currently only able to use the default built-in fee as there is no option to adjust the fee in the z_sendmany interface and no fee calculation policy has been agreed upon yet.

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Nov 14, 2016

Contributor

@ebfull @nathan-at-least @str4d Discussed during meeting. Please review and confirm ACK.

Contributor

bitcartel commented Nov 14, 2016

@ebfull @nathan-at-least @str4d Discussed during meeting. Please review and confirm ACK.

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 15, 2016

Contributor

ACK

@zkbot r+

Contributor

ebfull commented Nov 15, 2016

ACK

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

📌 Commit 1069848 has been approved by ebfull

Contributor

zkbot commented Nov 15, 2016

📌 Commit 1069848 has been approved by ebfull

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

⌛️ Testing commit 1069848 with merge 08d90e1...

Contributor

zkbot commented Nov 15, 2016

⌛️ Testing commit 1069848 with merge 08d90e1...

zkbot pushed a commit that referenced this pull request Nov 15, 2016

zkbot
Auto merge of #1855 - bitcartel:1719_1851_fee_adjustment_for_z_sendma…
…ny_tx, r=ebfull

Adjust fees to that z_sendmany tx using default built-in fee are not rejected by nodes

Resolves #1719 by setting min relay tx fee to 1000 to match upstream (they were experimenting wtih 5000 when zcash forked from upstream).

Temporary resolution for #1851 so that z_sendmany with thousands of taddr recipients will be accepted and not rejected because of insufficient fee.  Users are currently only able to use the default built-in fee as there is no option to adjust the fee in the z_sendmany interface and no fee calculation policy has been agreed upon yet.
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

💔 Test failed - zcash

Contributor

zkbot commented Nov 15, 2016

💔 Test failed - zcash

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Nov 15, 2016

Contributor

Investigating.

Contributor

bitcartel commented Nov 15, 2016

Investigating.

bitcartel added some commits Nov 14, 2016

Set default minrelaytxfee to 1000 zatoshis to match upstream.
A txout will be considered dust when it has a value <546 zatoshis.
Helps to address #1719.
Mempool will accept tx with joinsplits and the default z_sendmany fee.
Issue #1851 shows that a zaddr->taddr can be rejected from mempools
due to not meeting fee requirements given the size of the transaction.
Fee calculation for joinsplit txs has not yet been agreed upon, so
during this interim period, this patch ensures  joinsplit txs using
the default fee are not rejected due to an insufficient fee.
@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Nov 15, 2016

Contributor

Incorrect method name used in test. Now fixed to self.wait_and_assert_operationid_status(myopid).

Not doing zkbot retry as that failed on PR 1847.

@zkbot r+

Contributor

bitcartel commented Nov 15, 2016

Incorrect method name used in test. Now fixed to self.wait_and_assert_operationid_status(myopid).

Not doing zkbot retry as that failed on PR 1847.

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

📌 Commit 9ddb6ad has been approved by bitcartel

Contributor

zkbot commented Nov 15, 2016

📌 Commit 9ddb6ad has been approved by bitcartel

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

⌛️ Testing commit 9ddb6ad with merge 9ddb6ad...

Contributor

zkbot commented Nov 15, 2016

⌛️ Testing commit 9ddb6ad with merge 9ddb6ad...

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2016

Contributor

☀️ Test successful - zcash

Contributor

zkbot commented Nov 15, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 9ddb6ad into zcash:master Nov 15, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment