New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors and nullifiers should always be inherited from the parent cache. #1874

Merged
merged 2 commits into from Nov 17, 2016

Conversation

Projects
None yet
4 participants
@ebfull
Contributor

ebfull commented Nov 17, 2016

The CoinsCache abstraction, during flushing to its base cache, did not remove nullifiers or anchors from the base cache that were not brought into the base cache from a backing store (the transaction database on disk).

Closes #1769.

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 17, 2016

Contributor

This was reviewed by @daira, @bitcartel, @str4d, and others.

@zkbot r+

Contributor

ebfull commented Nov 17, 2016

This was reviewed by @daira, @bitcartel, @str4d, and others.

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 17, 2016

Contributor

📌 Commit f398a94 has been approved by ebfull

Contributor

zkbot commented Nov 17, 2016

📌 Commit f398a94 has been approved by ebfull

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 17, 2016

Contributor

⌛️ Testing commit f398a94 with merge f398a94...

Contributor

zkbot commented Nov 17, 2016

⌛️ Testing commit f398a94 with merge f398a94...

@ebfull ebfull referenced this pull request Nov 17, 2016

Closed

Zcash Daemon Sync Issues #1769

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 17, 2016

Contributor

💔 Test failed - zcash

Contributor

zkbot commented Nov 17, 2016

💔 Test failed - zcash

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 17, 2016

Contributor

test_bitcoin started using obscene amounts of memory and taking a long time to run, after these tests were added.

Contributor

ebfull commented Nov 17, 2016

test_bitcoin started using obscene amounts of memory and taking a long time to run, after these tests were added.

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 17, 2016

Contributor

It appears that adding new tests where we did changed the ordering of the tests, triggering a race condition that only exists in test_bitcoin because it initializes the curve parameters multiple times.

Contributor

ebfull commented Nov 17, 2016

It appears that adding new tests where we did changed the ordering of the tests, triggering a race condition that only exists in test_bitcoin because it initializes the curve parameters multiple times.

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Nov 17, 2016

Contributor

utACK bcb58b7

Contributor

daira commented Nov 17, 2016

utACK bcb58b7

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 17, 2016

Contributor

@zkbot r+

Contributor

ebfull commented Nov 17, 2016

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 17, 2016

Contributor

📌 Commit 13e9a63 has been approved by ebfull

Contributor

zkbot commented Nov 17, 2016

📌 Commit 13e9a63 has been approved by ebfull

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 17, 2016

Contributor

⌛️ Testing commit 13e9a63 with merge 13e9a63...

Contributor

zkbot commented Nov 17, 2016

⌛️ Testing commit 13e9a63 with merge 13e9a63...

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Nov 17, 2016

Contributor

Post-hoc utACK 13e9a63

Contributor

daira commented Nov 17, 2016

Post-hoc utACK 13e9a63

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 17, 2016

Contributor

☀️ Test successful - zcash

Contributor

zkbot commented Nov 17, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 13e9a63 into zcash:master Nov 17, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment