Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors and nullifiers should always be inherited from the parent cache. #1874

Merged
merged 2 commits into from Nov 17, 2016

Conversation

@ebfull
Copy link
Contributor

ebfull commented Nov 17, 2016

The CoinsCache abstraction, during flushing to its base cache, did not remove nullifiers or anchors from the base cache that were not brought into the base cache from a backing store (the transaction database on disk).

Closes #1769.

@ebfull
Copy link
Contributor Author

ebfull commented Nov 17, 2016

This was reviewed by @daira, @bitcartel, @str4d, and others.

@zkbot r+

@zkbot
Copy link
Collaborator

zkbot commented Nov 17, 2016

📌 Commit f398a94 has been approved by ebfull

@zkbot
Copy link
Collaborator

zkbot commented Nov 17, 2016

Testing commit f398a94 with merge f398a94...

@ebfull ebfull mentioned this pull request Nov 17, 2016
@zkbot
Copy link
Collaborator

zkbot commented Nov 17, 2016

💔 Test failed - zcash

@ebfull
Copy link
Contributor Author

ebfull commented Nov 17, 2016

test_bitcoin started using obscene amounts of memory and taking a long time to run, after these tests were added.

@ebfull
Copy link
Contributor Author

ebfull commented Nov 17, 2016

It appears that adding new tests where we did changed the ordering of the tests, triggering a race condition that only exists in test_bitcoin because it initializes the curve parameters multiple times.

@ebfull ebfull force-pushed the ebfull:fix-cache-bug branch from 8ed27aa to bcb58b7 Nov 17, 2016
@daira
Copy link
Contributor

daira commented Nov 17, 2016

utACK bcb58b7

@ebfull ebfull force-pushed the ebfull:fix-cache-bug branch from bcb58b7 to f398a94 Nov 17, 2016
@ebfull
Copy link
Contributor Author

ebfull commented Nov 17, 2016

@zkbot r+

@zkbot
Copy link
Collaborator

zkbot commented Nov 17, 2016

📌 Commit 13e9a63 has been approved by ebfull

@zkbot
Copy link
Collaborator

zkbot commented Nov 17, 2016

Testing commit 13e9a63 with merge 13e9a63...

@daira
Copy link
Contributor

daira commented Nov 17, 2016

Post-hoc utACK 13e9a63

@zkbot
Copy link
Collaborator

zkbot commented Nov 17, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 13e9a63 into zcash:master Nov 17, 2016
1 check passed
1 check passed
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.