Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch miner to P2PKH, add -mineraddress option #1965
bitcartel left a comment •
There is no error if the mineraddress is invalid, whether empty whitespace, garbage or an address with a typo.
Instead, mining proceeds successfully with the coinbase reward going to address tm9iMLAuYMzJ6jtFLcA7rzUmfreGuKvr7Ma.
This is the address when keyID is null.
./zcash-cli validateaddress tm9iMLAuYMzJ6jtFLcA7rzUmfreGuKvr7Ma
The above should be fixed and automated tests written to check input validity and spending the coinbase.
Also consider adding an option -mineraddressismine (default true) where the user must explicitly set this to false to allow mining to an address not in the wallet.
Reporting problems with the miner address, whether invalid or not mine, should be at launch so that the user is notified immediately.
@str4d Getting compile errors:
@str4d compile error
referenced this pull request
Feb 9, 2017
If I disable the wallet (by editing