New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental feature: remote proving service #2120

Open
wants to merge 8 commits into
base: master
from

Conversation

@str4d
Contributor

str4d commented Feb 22, 2017

This implements proving service support in z_sendmany and adds two new binaries:

  • zcash-proving-service: listens on (one or both of) ZMQ and WebSocket ports for witness data, and returns the corresponding proof.
  • ExampleProvingServiceClient (in src/zcash): creates five new JSDescriptions using the proving service to calculate the proofs, and validates each proof.

To build: CONFIGURE_FLAGS="--with-proving-service-daemon" ./zcutil/build.sh

This is an experimental feature, and the network protocol is likely to change. Until the protocol has been specified in a ZIP, do not rely on it for interoperation.

Part of #1113. Closes #2066.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Feb 22, 2017

Contributor

Side note: I expect we will move, rename, or remove zcash-prover-client, as it is only an example. What we will want is to bundle its contents into the z_sendmany backend.

Contributor

str4d commented Feb 22, 2017

Side note: I expect we will move, rename, or remove zcash-prover-client, as it is only an example. What we will want is to bundle its contents into the z_sendmany backend.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Mar 10, 2017

Contributor

Renamed the binaries and added a conditional compilation flag.

Contributor

str4d commented Mar 10, 2017

Renamed the binaries and added a conditional compilation flag.

@str4d str4d changed the title from [WIP] Standalone proving service and demo client to Standalone proving service and demo client Mar 10, 2017

@str4d str4d added the review needed label Mar 10, 2017

@str4d str4d added this to the 1.0.8 milestone Mar 10, 2017

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Mar 10, 2017

Contributor

Adjusted the wire protocol to take a list of JSProofWitness objects, made the number of JSDescriptions in the example client configurable, and added an env var for setting ./configure flags so that we can easily build this on the CI (per #1113 (comment)).

Contributor

str4d commented Mar 10, 2017

Adjusted the wire protocol to take a list of JSProofWitness objects, made the number of JSDescriptions in the example client configurable, and added an env var for setting ./configure flags so that we can easily build this on the CI (per #1113 (comment)).

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Mar 11, 2017

Contributor

☔️ The latest upstream changes (presumably #1636) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

zkbot commented Mar 11, 2017

☔️ The latest upstream changes (presumably #1636) made this pull request unmergeable. Please resolve the merge conflicts.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Mar 15, 2017

Contributor

@nathan-at-least as-is, this protocol still enables DP-Z with trusted proving services. I know you wanted what we land as DP-T to not support trusted proving services, but given that there will be a client library in front, is it sufficient for that library to provide a DP-T-only API?

Contributor

str4d commented Mar 15, 2017

@nathan-at-least as-is, this protocol still enables DP-Z with trusted proving services. I know you wanted what we land as DP-T to not support trusted proving services, but given that there will be a client library in front, is it sufficient for that library to provide a DP-T-only API?

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Mar 21, 2017

Contributor

☔️ The latest upstream changes (presumably #2183) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

zkbot commented Mar 21, 2017

☔️ The latest upstream changes (presumably #2183) made this pull request unmergeable. Please resolve the merge conflicts.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Mar 21, 2017

Contributor

@nathan-at-least I can't remember whether you wanted to bump this from 1.0.8; if yes, then the merge conflict above should resolve itself once the --disable-rust commit from #2183 is reverted.

Contributor

str4d commented Mar 21, 2017

@nathan-at-least I can't remember whether you wanted to bump this from 1.0.8; if yes, then the merge conflict above should resolve itself once the --disable-rust commit from #2183 is reverted.

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Mar 21, 2017

Contributor

@arcalinea and I bumped this from 1.0.8, and @nathan-at-least concurred on #zcash-dev.

As far as I understand, that commit (802ea76) will not be reverted for 1.0.9, but payment offloading is in the 1.0.9 milestone, so this conflict does need to be resolved.

Contributor

daira commented Mar 21, 2017

@arcalinea and I bumped this from 1.0.8, and @nathan-at-least concurred on #zcash-dev.

As far as I understand, that commit (802ea76) will not be reverted for 1.0.9, but payment offloading is in the 1.0.9 milestone, so this conflict does need to be resolved.

@str4d str4d modified the milestones: 1.0.9, 1.0.8 Mar 21, 2017

Show outdated Hide outdated configure.ac Outdated
@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Apr 5, 2017

Contributor

Rebased on master.

Contributor

str4d commented Apr 5, 2017

Rebased on master.

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Apr 11, 2017

Contributor

Concept ACK, some things might be twisted around because of #2243 though.

Contributor

ebfull commented Apr 11, 2017

Concept ACK, some things might be twisted around because of #2243 though.

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Apr 16, 2017

Contributor

☔️ The latest upstream changes (presumably #2189) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

zkbot commented Apr 16, 2017

☔️ The latest upstream changes (presumably #2189) made this pull request unmergeable. Please resolve the merge conflicts.

@daira daira modified the milestones: 1.0.10, 1.0.9 Apr 16, 2017

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Apr 17, 2017

Contributor

Moving 1.0.10 tickets back into 1.0.9 since the latter has been rescheduled.

Contributor

daira commented Apr 17, 2017

Moving 1.0.10 tickets back into 1.0.9 since the latter has been rescheduled.

}
if (argc < 3 || numJSDescs <= 0) {
std::cerr << "Usage: ExampleProvingServiceClient [provingServiceAddress] [provingServicePubKey] (numJSDescs)" << std::endl;
std::cerr << "provingServiceAddress is a ZMQ address, e.g. tcp://localhost:8234" << std::endl;

This comment has been minimized.

@arielgabizon

arielgabizon Dec 20, 2017

Contributor

given an example of what to write for provingServicePubKey?

@arielgabizon

arielgabizon Dec 20, 2017

Contributor

given an example of what to write for provingServicePubKey?

This comment has been minimized.

@arielgabizon

arielgabizon Dec 21, 2017

Contributor

(I'm not sure how to run the example cause of this)

@arielgabizon

arielgabizon Dec 21, 2017

Contributor

(I'm not sure how to run the example cause of this)

This comment has been minimized.

@str4d

str4d Dec 21, 2017

Contributor

Done

@str4d

str4d Dec 21, 2017

Contributor

Done

This comment has been minimized.

@arielgabizon

arielgabizon Dec 21, 2017

Contributor

Don't follow. How to get a public key?

@arielgabizon

arielgabizon Dec 21, 2017

Contributor

Don't follow. How to get a public key?

Show outdated Hide outdated src/init.cpp Outdated
$(package)_download_path=https://github.com/zeromq/$(package)/archive/
$(package)_file_name=$(package)-$($(package)_version).tar.gz
$(package)_download_file=v$($(package)_version).tar.gz
$(package)_sha256_hash=c204c731bcb7810ca3a2c5515e88974ef2ff8d0589e60a897dc238b369180e7b

This comment has been minimized.

@bitcartel

bitcartel Dec 21, 2017

Contributor

latest version?

@bitcartel

bitcartel Dec 21, 2017

Contributor

latest version?

This comment has been minimized.

@str4d

str4d Dec 21, 2017

Contributor

Looks like it, although there have been numerous commits to master since then.

@str4d

str4d Dec 21, 2017

Contributor

Looks like it, although there have been numerous commits to master since then.

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

I may be misinterpreting, but this recently fixed ticket looks like a memory safety bug: zeromq/azmq#111

Not to worry, that was before the 1.0 release.

@daira

daira Dec 22, 2017

Contributor

I may be misinterpreting, but this recently fixed ticket looks like a memory safety bug: zeromq/azmq#111

Not to worry, that was before the 1.0 release.

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

zeromq/azmq#129 is a reliability bug.

@daira

daira Dec 22, 2017

Contributor

zeromq/azmq#129 is a reliability bug.

Show outdated Hide outdated depends/packages/cppzmq.mk Outdated
@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Dec 21, 2017

Contributor

Just a few minor things mentioned above.
Btw, are all the new dependencies staged?
@zkbot try

Contributor

bitcartel commented Dec 21, 2017

Just a few minor things mentioned above.
Btw, are all the new dependencies staged?
@zkbot try

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Dec 21, 2017

Contributor

@bitcartel I believe that the try above was non-responsive because this commit has already been successfully try-ed.

Contributor

str4d commented Dec 21, 2017

@bitcartel I believe that the try above was non-responsive because this commit has already been successfully try-ed.

str4d added some commits Dec 21, 2017

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Dec 21, 2017

Contributor

Addressed comments by @arielgabizon and @bitcartel.

Contributor

str4d commented Dec 21, 2017

Addressed comments by @arielgabizon and @bitcartel.

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel Dec 21, 2017

Contributor

@zkbot retry

Contributor

bitcartel commented Dec 21, 2017

@zkbot retry

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Dec 21, 2017

Contributor

@zkbot try

Contributor

str4d commented Dec 21, 2017

@zkbot try

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Dec 21, 2017

Contributor

⌛️ Trying commit 1bfe584 with merge 2ab81dd...

Contributor

zkbot commented Dec 21, 2017

⌛️ Trying commit 1bfe584 with merge 2ab81dd...

zkbot added a commit that referenced this pull request Dec 21, 2017

Auto merge of #2120 - str4d:1113-dpt, r=<try>
Experimental feature: remote proving service

This implements proving service support in `z_sendmany` and adds two new binaries:

- `zcash-proving-service`: listens on (one or both of) ZMQ and WebSocket ports for witness data, and returns the corresponding proof.
- `ExampleProvingServiceClient` (in `src/zcash`): creates five new `JSDescription`s using the proving service to calculate the proofs, and validates each proof.

To build: `CONFIGURE_FLAGS="--with-proving-service-daemon" ./zcutil/build.sh`

This is an experimental feature, and the network protocol is likely to change. Until the protocol has been specified in a ZIP, do not rely on it for interoperation.

Part of #1113. Closes #2066.
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Dec 21, 2017

Contributor

☀️ Test successful - pr-try
State: approved= try=True

Contributor

zkbot commented Dec 21, 2017

☀️ Test successful - pr-try
State: approved= try=True

@arielgabizon

This comment has been minimized.

Show comment
Hide comment
@arielgabizon

arielgabizon Dec 21, 2017

Contributor

I'm not getting the zcash-proving-service executable when compiling as instructed.

Contributor

arielgabizon commented Dec 21, 2017

I'm not getting the zcash-proving-service executable when compiling as instructed.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Dec 22, 2017

Contributor

@arielgabizon the file should be generated as src/zcash-proving-service. Check the build output to ensure that it is enabled in configure, and compiled / linked?

Contributor

str4d commented Dec 22, 2017

@arielgabizon the file should be generated as src/zcash-proving-service. Check the build output to ensure that it is enabled in configure, and compiled / linked?

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Dec 22, 2017

Contributor

Unfortunately, this still does not have any ACKs, and there are now only three work days until the 1.0.14 release, so I'm bumping this to 1.0.15.

Contributor

str4d commented Dec 22, 2017

Unfortunately, this still does not have any ACKs, and there are now only three work days until the 1.0.14 release, so I'm bumping this to 1.0.15.

@str4d str4d modified the milestones: 1.0.14, 1.0.15 Dec 22, 2017

@str4d str4d moved this from 1.0.14: Experimental Features to 1.0.15: Experimental Features in Release planning Dec 22, 2017

@arielgabizon

This comment has been minimized.

Show comment
Hide comment
@arielgabizon

arielgabizon Dec 22, 2017

Contributor

My mistake I did have zcash-proving-service

What exactly do I copy as the public key?
image

+YR%:NhHPZOa6=8RrjVYX82s%@.nVAh]?/Re{yog gave an error
image

Contributor

arielgabizon commented Dec 22, 2017

My mistake I did have zcash-proving-service

What exactly do I copy as the public key?
image

+YR%:NhHPZOa6=8RrjVYX82s%@.nVAh]?/Re{yog gave an error
image

@arielgabizon

This comment has been minimized.

Show comment
Hide comment
@arielgabizon

arielgabizon Dec 22, 2017

Contributor

I should be able to ack today/monday, if I manage to run the code.
Also I strongly feel JSProofWitness should be changed to JSWitness

Contributor

arielgabizon commented Dec 22, 2017

I should be able to ack today/monday, if I manage to run the code.
Also I strongly feel JSProofWitness should be changed to JSWitness

Show outdated Hide outdated src/zcash/JoinSplit.hpp Outdated
@@ -59,7 +83,7 @@ class JoinSplit {
const uint256& pubKeyHash
);
virtual ZCProof prove(
virtual JSProofWitness<NumInputs, NumOutputs> witness(

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

No opinion. The spec doesn't have a name for this (it's not the same as the primary input or the auxiliary input, because those have more redundancy).

@daira

daira Dec 22, 2017

Contributor

No opinion. The spec doesn't have a name for this (it's not the same as the primary input or the auxiliary input, because those have more redundancy).

# Copying and distribution of this file, with or without modification, are
# permitted in any medium without royalty provided the copyright notice
# and this notice are preserved. This file is offered as-is, without any
# warranty.

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

Add this to contrib/debian/copyright:

Files: build-aux/m4/ax_boost_regex.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2008 Michael Tindal
License: GNU-All-permissive-License

Actually there should be similar entries for all of the files under build-aux/m4:

Files: build-aux/m4/ax_boost_base.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2009 Peter Adolphs
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_chrono.m4
Copyright: 2012 Xiyue Deng <manphiz@gmail.com>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_filesystem.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2009 Michael Tindal;
 2009 Roman Rybalko <libtorrent@romanr.info>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_program_options.m4;
 build-aux/m4/ax_boost_unit_test_framework.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_system.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2008 Michael Tindal;
 2008 Daniel Casimiro <dan.casimiro@gmail.com>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_cxx_compile_stdcxx.m4
Copyright: 2008 Benjamin Kosnik <bkoz@redhat.com>;
 2012 Zack Weinberg <zackw@panix.com>;
 2013 Roy Stogner <roystgnr@ices.utexas.edu>;
 2014, 2015 Google Inc. contributed by Alexey Sokolov <sokolov@google.com>;
 2015 Paul Norman <penorman@mac.com>;
 2015 Moritz Klammler <moritz@klammler.eu>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_gcc_func_attribute.m4
Copyright: 2013 Gabriele Svelto <gabriele.svelto@gmail.com>
License: GNU-All-permissive-License

Files: build-aux/m4/l_atomic.m4
Copyright: 2004-2017 Tim Kosse
License: GPLv2

Files: build-aux/m4/ax_check_compile_flag.m4;
 build-aux/m4/ax_check_link_flag.m4;
 build-aux/m4/ax_check_preproc_flag.m4
Copyright: 2008 Guido U. Draheim <guidod@gmx.de>;
 2011 Maarten Bosmans <mkbosmans@gmail.com>
License: GPLv3-with-Autoconf-Macro-exception

Files: build-aux/m4/ax_openmp.m4
Copyright: 2008 Steven G. Johnson <stevenj@alum.mit.edu>;
 2015 John W. Peterson <jwpeterson@gmail.com>;
 2016 Nick R. Papior <nickpapior@gmail.com>
License: GPLv3-with-Autoconf-Macro-exception

Files: build-aux/m4/ax_pthread.m4
Copyright: 2008 Steven G. Johnson <stevenj@alum.mit.edu>;
 2011 Daniel Richard G. <skunk@iSKUNK.ORG>
License: GPLv3-with-Autoconf-Macro-exception

License: GPLv3-with-Autoconf-Macro-exception
 This program is free software: you can redistribute it and/or modify it
 under the terms of the GNU General Public License as published by the
 Free Software Foundation, either version 3 of the License, or (at your
 option) any later version.
 .
 This program is distributed in the hope that it will be useful, but
 WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 See the GNU General Public License for more details.
 .
 You should have received a copy of the GNU General Public License along
 with this program. If not, see <http://www.gnu.org/licenses/>.
 .
 As a special exception, the respective Autoconf Macro's copyright owner
 gives unlimited permission to copy, distribute and modify the configure
 scripts that are the output of Autoconf when processing the Macro. You
 need not follow the terms of the GNU General Public License when using
 or distributing such scripts, even though portions of the text of the
 Macro appear in them. The GNU General Public License (GPL) does govern
 all other use of the material that constitutes the Autoconf Macro.
 .
 This special exception to the GPL applies to versions of the Autoconf
 Macro released by the Autoconf Archive. When you make and distribute a
 modified version of the Autoconf Macro, you may extend this special
 exception to the GPL to apply to your modified version as well.

build-aux/m4/l_atomic.m4 comes from Filezilla which is GPLv2. This is a problem, which I will file another ticket for.

@daira

daira Dec 22, 2017

Contributor

Add this to contrib/debian/copyright:

Files: build-aux/m4/ax_boost_regex.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2008 Michael Tindal
License: GNU-All-permissive-License

Actually there should be similar entries for all of the files under build-aux/m4:

Files: build-aux/m4/ax_boost_base.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2009 Peter Adolphs
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_chrono.m4
Copyright: 2012 Xiyue Deng <manphiz@gmail.com>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_filesystem.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2009 Michael Tindal;
 2009 Roman Rybalko <libtorrent@romanr.info>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_program_options.m4;
 build-aux/m4/ax_boost_unit_test_framework.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_boost_system.m4
Copyright: 2008 Thomas Porschberg <thomas@randspringer.de>;
 2008 Michael Tindal;
 2008 Daniel Casimiro <dan.casimiro@gmail.com>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_cxx_compile_stdcxx.m4
Copyright: 2008 Benjamin Kosnik <bkoz@redhat.com>;
 2012 Zack Weinberg <zackw@panix.com>;
 2013 Roy Stogner <roystgnr@ices.utexas.edu>;
 2014, 2015 Google Inc. contributed by Alexey Sokolov <sokolov@google.com>;
 2015 Paul Norman <penorman@mac.com>;
 2015 Moritz Klammler <moritz@klammler.eu>
License: GNU-All-permissive-License

Files: build-aux/m4/ax_gcc_func_attribute.m4
Copyright: 2013 Gabriele Svelto <gabriele.svelto@gmail.com>
License: GNU-All-permissive-License

Files: build-aux/m4/l_atomic.m4
Copyright: 2004-2017 Tim Kosse
License: GPLv2

Files: build-aux/m4/ax_check_compile_flag.m4;
 build-aux/m4/ax_check_link_flag.m4;
 build-aux/m4/ax_check_preproc_flag.m4
Copyright: 2008 Guido U. Draheim <guidod@gmx.de>;
 2011 Maarten Bosmans <mkbosmans@gmail.com>
License: GPLv3-with-Autoconf-Macro-exception

Files: build-aux/m4/ax_openmp.m4
Copyright: 2008 Steven G. Johnson <stevenj@alum.mit.edu>;
 2015 John W. Peterson <jwpeterson@gmail.com>;
 2016 Nick R. Papior <nickpapior@gmail.com>
License: GPLv3-with-Autoconf-Macro-exception

Files: build-aux/m4/ax_pthread.m4
Copyright: 2008 Steven G. Johnson <stevenj@alum.mit.edu>;
 2011 Daniel Richard G. <skunk@iSKUNK.ORG>
License: GPLv3-with-Autoconf-Macro-exception

License: GPLv3-with-Autoconf-Macro-exception
 This program is free software: you can redistribute it and/or modify it
 under the terms of the GNU General Public License as published by the
 Free Software Foundation, either version 3 of the License, or (at your
 option) any later version.
 .
 This program is distributed in the hope that it will be useful, but
 WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 See the GNU General Public License for more details.
 .
 You should have received a copy of the GNU General Public License along
 with this program. If not, see <http://www.gnu.org/licenses/>.
 .
 As a special exception, the respective Autoconf Macro's copyright owner
 gives unlimited permission to copy, distribute and modify the configure
 scripts that are the output of Autoconf when processing the Macro. You
 need not follow the terms of the GNU General Public License when using
 or distributing such scripts, even though portions of the text of the
 Macro appear in them. The GNU General Public License (GPL) does govern
 all other use of the material that constitutes the Autoconf Macro.
 .
 This special exception to the GPL applies to versions of the Autoconf
 Macro released by the Autoconf Archive. When you make and distribute a
 modified version of the Autoconf Macro, you may extend this special
 exception to the GPL to apply to your modified version as well.

build-aux/m4/l_atomic.m4 comes from Filezilla which is GPLv2. This is a problem, which I will file another ticket for.

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

That other ticket is #2827.

@daira

daira Dec 22, 2017

Contributor

That other ticket is #2827.

$(package)_download_path=https://github.com/zeromq/$(package)/archive/
$(package)_file_name=$(package)-$($(package)_version).tar.gz
$(package)_download_file=v$($(package)_version).tar.gz
$(package)_sha256_hash=c204c731bcb7810ca3a2c5515e88974ef2ff8d0589e60a897dc238b369180e7b

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

I may be misinterpreting, but this recently fixed ticket looks like a memory safety bug: zeromq/azmq#111

Not to worry, that was before the 1.0 release.

@daira

daira Dec 22, 2017

Contributor

I may be misinterpreting, but this recently fixed ticket looks like a memory safety bug: zeromq/azmq#111

Not to worry, that was before the 1.0 release.

$(package)_download_path=https://github.com/zeromq/$(package)/archive/
$(package)_file_name=$(package)-$($(package)_version).tar.gz
$(package)_download_file=v$($(package)_version).tar.gz
$(package)_sha256_hash=c204c731bcb7810ca3a2c5515e88974ef2ff8d0589e60a897dc238b369180e7b

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

zeromq/azmq#129 is a reliability bug.

@daira

daira Dec 22, 2017

Contributor

zeromq/azmq#129 is a reliability bug.

Show outdated Hide outdated src/primitives/transaction.cpp Outdated
Show outdated Hide outdated src/zcash-proving-service.cpp Outdated
zmq::message_t reply;
LogPrint("zrpc", "%s: Waiting for proofs…\n", log_id);
// Add 5% margin to timeout for overhead

This comment has been minimized.

@daira

daira Dec 22, 2017

Contributor

Is this enough margin? I'd suggest 10% plus 5 seconds.

@daira

daira Dec 22, 2017

Contributor

Is this enough margin? I'd suggest 10% plus 5 seconds.

Show outdated Hide outdated src/wallet/asyncrpcoperation_sendmany.cpp Outdated
@daira

daira approved these changes Dec 22, 2017

utACK

@str4d str4d moved this from 1.0.15: Experimental Features to 1.1.0: Experimental Features in Release planning Feb 8, 2018

@str4d str4d modified the milestones: 1.0.15, 1.1.0 Feb 8, 2018

@str4d str4d removed this from 1.1.0: Experimental Features in Release planning Mar 20, 2018

@str4d str4d removed this from the v1.1.0 milestone Mar 20, 2018

@saleemrashid

This comment has been minimized.

Show comment
Hide comment
@saleemrashid

saleemrashid Jun 2, 2018

From what I can tell, this doesn't support trustless (i.e. without having the private keys) Z proving, right?

Is this still a limitation in Sapling or could this be updated to support it after Sapling activates?

Edit: Disregard this, I have found the DP-Z proposal here #2171 (comment) 😄

Edit 2: On second thoughts, that looks like an abandoned feature?

saleemrashid commented Jun 2, 2018

From what I can tell, this doesn't support trustless (i.e. without having the private keys) Z proving, right?

Is this still a limitation in Sapling or could this be updated to support it after Sapling activates?

Edit: Disregard this, I have found the DP-Z proposal here #2171 (comment) 😄

Edit 2: On second thoughts, that looks like an abandoned feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment