New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sending from a zaddr, minconf cannot be zero. #2525

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
5 participants
@bitcartel
Contributor

bitcartel commented Jul 11, 2017

Closes #2519.

@str4d

str4d approved these changes Jul 12, 2017

utACK

@str4d str4d changed the title from Fixes #2519. When sending from a zaddr, minconf cannot be zero. to When sending from a zaddr, minconf cannot be zero. Jul 12, 2017

@daira

daira approved these changes Jul 12, 2017

ut(ACK+cov)

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Jul 20, 2017

Contributor

@zkbot r+. (I looked whether the order of merging this and #2526 matters, and I don't think it does.)

Contributor

daira commented Jul 20, 2017

@zkbot r+. (I looked whether the order of merging this and #2526 matters, and I don't think it does.)

@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Jul 20, 2017

Contributor

side-eyes Homu

@zkbot r+

Contributor

daira commented Jul 20, 2017

side-eyes Homu

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Jul 20, 2017

Contributor

📌 Commit b639bb1 has been approved by daira

Contributor

zkbot commented Jul 20, 2017

📌 Commit b639bb1 has been approved by daira

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Jul 20, 2017

Contributor

⌛️ Testing commit b639bb1 with merge 95d1878...

Contributor

zkbot commented Jul 20, 2017

⌛️ Testing commit b639bb1 with merge 95d1878...

zkbot added a commit that referenced this pull request Jul 20, 2017

Auto merge of #2525 - bitcartel:2519_no_zero_minconf_from_zaddr_zsend…
…many, r=daira

When sending from a zaddr, minconf cannot be zero.

Closes #2519.
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Jul 20, 2017

Contributor

☀️ Test successful - pr-merge
Approved by: daira
Pushing 95d1878 to master...

Contributor

zkbot commented Jul 20, 2017

☀️ Test successful - pr-merge
Approved by: daira
Pushing 95d1878 to master...

@zkbot zkbot merged commit b639bb1 into zcash:master Jul 20, 2017

1 check passed

homu Test successful
Details

zkbot added a commit that referenced this pull request Jul 28, 2017

Auto merge of #2526 - bitcartel:2480_segfault_zeroconf_from_zaddr, r=…
…daira

Fixes #2480 where missing map entry would cause a segfault.

`wtxHeight = mapBlockIndex[wtx.hashBlock]->nHeight;` results in undefined behaviour when the block hash is not present in the map, returning a null value which is dereferenced via `->nHeight`.  This error is triggered by a zero-conf wallet transaction which has not been mined yet.  As discussed in #2480, on some systems there is a segfault whilst on others there is a silent exit.  This makes it difficult to write a test, but the fix has been tested empirically to confirm an exception is thrown.  This PR fixes the segfault and complements #2525 which prevents a user from sending from a zaddr with minconf 0.
@arielgabizon

This comment has been minimized.

Show comment
Hide comment
@arielgabizon

arielgabizon Jul 28, 2017

Contributor

Great fix! I tried it.

Contributor

arielgabizon commented Jul 28, 2017

Great fix! I tried it.

@daira daira added this to Complete in Security and Stability Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment