New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for listunspent #2650

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
5 participants
@str4d
Contributor

str4d commented Oct 4, 2017

Closes #2645.

@str4d str4d added this to the 1.0.13 CI release milestone Oct 4, 2017

@str4d str4d requested review from arielgabizon and daira Oct 4, 2017

@daira

daira approved these changes Oct 10, 2017

utACK

@bitcartel bitcartel self-requested a review Oct 12, 2017

UniValue params(UniValue::VARR);
struct timeval tv_start;
timer_start(tv_start);
auto unspent = listunspent(params, false);

This comment has been minimized.

@bitcartel

bitcartel Oct 12, 2017

Contributor

Local variable unspent is not used... do we need to store the result of calling listunspent?

@bitcartel

bitcartel Oct 12, 2017

Contributor

Local variable unspent is not used... do we need to store the result of calling listunspent?

This comment has been minimized.

@str4d

str4d Oct 12, 2017

Contributor

Ah, no we don't need to, but unfortunately GitHub didn't show me this feedback until after I r+ed the PR. Looks like there's at least one other instance of this however, so I'll make a follow-up cleanup PR.

@str4d

str4d Oct 12, 2017

Contributor

Ah, no we don't need to, but unfortunately GitHub didn't show me this feedback until after I r+ed the PR. Looks like there's at least one other instance of this however, so I'll make a follow-up cleanup PR.

@bitcartel

See comment about 'auto unspent'.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Oct 12, 2017

Contributor

@zkbot r+

Contributor

str4d commented Oct 12, 2017

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 12, 2017

Contributor

📌 Commit 99dd50c has been approved by str4d

Contributor

zkbot commented Oct 12, 2017

📌 Commit 99dd50c has been approved by str4d

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 12, 2017

Contributor

⌛️ Testing commit 99dd50c with merge af549fe...

Contributor

zkbot commented Oct 12, 2017

⌛️ Testing commit 99dd50c with merge af549fe...

zkbot added a commit that referenced this pull request Oct 12, 2017

Will address comment in a follow-up PR.

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Oct 12, 2017

Contributor

☀️ Test successful - pr-merge
Approved by: str4d
Pushing af549fe to master...

Contributor

zkbot commented Oct 12, 2017

☀️ Test successful - pr-merge
Approved by: str4d
Pushing af549fe to master...

@zkbot zkbot merged commit 99dd50c into zcash:master Oct 12, 2017

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment