When rewinding, remove insufficiently-validated blocks #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
added
C-bug
|
Related to #3100, which is tangentially similar. |
daira
approved these changes
Mar 31, 2018
|
That's what I was blocking on - trying to figure out a nice way to test it. I think I'll have to do the not-so-nice thing where we emulate the "switching clients" behaviour by stopping and starting nodes in an RPC test. |
|
I have (what I believe is) an RPC test for |
str4d
force-pushed
the
2898-rewind-block-index
branch
from
091f5a0
to
e09ad78
Compare
str4d
changed the title
|
This PR now has an RPC test that fails before the fix, and passes afterwards. |
str4d
force-pushed
the
2898-rewind-block-index
branch
from
e09ad78
to
fcf908f
Compare
|
Force-pushed to fix PyFlakes warning 😄 |
bitcartel
approved these changes
Apr 3, 2018
daira
requested changes
Apr 3, 2018
qa/rpc-tests/rewind_index.py
Outdated
| assert_equal(self.nodes[2].getbestblockhash(), block10o) | ||
|
|
||
| # Restart node 0 using Sprout instead of Overwinter | ||
| print("Switching node 0 from Sprout to Overwinter") |
qa/rpc-tests/rewind_index.py
Outdated
| assert_equal(self.nodes[0].getbestblockhash(), block10s) | ||
|
|
||
| # Restart node 0 using Overwinter instead of Sprout | ||
| print("Switching node 0 from Overwinter to Sprout") |
If a block is insufficiently-validated against a particular branch ID, then we cannot guarantee that even the block header will be valid under the actual consensus rules the node will want to apply. Instead require that the blocks are completely re-validated, by removing them from the block index (which is equivalent to reducing their validity to BLOCK_VALID_UNKNOWN).
str4d
force-pushed
the
2898-rewind-block-index
branch
from
fcf908f
to
f5007d8
Compare
|
@zkbot r+ |
|
📌 Commit f5007d8 has been approved by |
zkbot
added a commit
that referenced
this pull request
Apr 3, 2018
When rewinding, remove insufficiently-validated blocks If a block is insufficiently-validated against a particular branch ID, then we cannot guarantee that even the block header will be valid under the actual consensus rules the node will want to apply. Instead require that the blocks are completely re-validated, by removing them from the block index (which is equivalent to reducing their validity to BLOCK_VALID_UNKNOWN). Closes #3100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a block is insufficiently-validated against a particular branch ID, then we
cannot guarantee that even the block header will be valid under the actual
consensus rules the node will want to apply. Instead require that the blocks are
completely re-validated, by removing them from the block index (which is
equivalent to reducing their validity to BLOCK_VALID_UNKNOWN).
Closes #3100.