New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config option -disabledeprecation #3137

Merged
merged 2 commits into from Jun 12, 2018

Conversation

6 participants
@str4d
Copy link
Contributor

str4d commented Apr 3, 2018

Closes #2943.

@str4d str4d added the dev policy label Apr 3, 2018

support from them).

Either way, it is much clearer that the software they are running is not
supported by the Zcash Company.

This comment has been minimized.

@str4d

str4d Apr 3, 2018

Contributor

I based these notes on the comments in #2943, but they need review. C/c @zookozcash @ioptio

@braddmiller braddmiller self-requested a review Apr 4, 2018

@braddmiller
Copy link
Contributor

braddmiller left a comment

tested ACK

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Apr 5, 2018

☔️ The latest upstream changes (presumably #2814) made this pull request unmergeable. Please resolve the merge conflicts.

@daira
Copy link
Contributor

daira left a comment

Code utACK, but I disagree with merging this until we have Windows and Mac support in the ZcashCo-provided zcashd.

[Edit: I withdrew this objection in https://github.com//issues/2943#issuecomment-394829066 ]

@bitcartel bitcartel force-pushed the str4d:2943-remove-auto-senescence-option branch from c989065 to 74c2f88 Jun 11, 2018

@mdr0id

This comment has been minimized.

Copy link
Contributor

mdr0id commented Jun 11, 2018

@zkbot try

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 11, 2018

⌛️ Trying commit 74c2f88 with merge aefba39...

zkbot added a commit that referenced this pull request Jun 11, 2018

Auto merge of #3137 - str4d:2943-remove-auto-senescence-option, r=<try>
Remove config option -disabledeprecation

Closes #2943.
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 11, 2018

☀️ Test successful - pr-try
State: approved= try=True

@mdr0id mdr0id self-requested a review Jun 12, 2018

@mdr0id

mdr0id approved these changes Jun 12, 2018

Copy link
Contributor

mdr0id left a comment

Tested ACK

@ebfull

This comment has been minimized.

Copy link
Contributor

ebfull commented Jun 12, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 12, 2018

📌 Commit 74c2f88 has been approved by ebfull

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 12, 2018

⌛️ Testing commit 74c2f88 with merge 524171d...

zkbot added a commit that referenced this pull request Jun 12, 2018

Auto merge of #3137 - str4d:2943-remove-auto-senescence-option, r=ebfull
Remove config option -disabledeprecation

Closes #2943.
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 12, 2018

☀️ Test successful - pr-merge
Approved by: ebfull
Pushing 524171d to master...

@zkbot zkbot merged commit 74c2f88 into zcash:master Jun 12, 2018

1 check passed

homu Test successful
Details

@str4d str4d added this to the v1.1.2 milestone Jun 19, 2018

@str4d str4d added this to Released (Merged in Master) in Zcashd Team Jun 19, 2018

@str4d str4d deleted the str4d:2943-remove-auto-senescence-option branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment