New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable building libzcashconsensus by default #3153

Merged
merged 1 commit into from Apr 14, 2018

Conversation

@str4d
Contributor

str4d commented Apr 6, 2018

The library is not currently a supported build artifact; it needs work in
order to build on certain platforms (e.g. MacOS), and its dependencies need to
be narrowed down (Equihash is not a requirement for validating scripts).

Disable building libzcashconsensus by default
The library is not currently a supported build artifact; it needs work in
order to build on certain platforms (e.g. MacOS), and its dependencies need to
be narrowed down (Equihash is not a requirement for validating scripts).

@str4d str4d added this to the v1.1.1 milestone Apr 6, 2018

@str4d

This comment has been minimized.

Contributor

str4d commented Apr 6, 2018

This will also remove a blocker for MacOS / clang support (which complains about e.g. libsodium not being linked in). We will add --with-libs to the kitchensink builder in CI, so that we continue to ensure the zcashconsensus.cpp wrapper remains compilable (all other parts of the library are used in zcashd itself, and remain tested).

@str4d str4d added this to 1.1.1: Build System in Release planning Apr 6, 2018

@str4d str4d added this to Implemented — Waiting for ACKs in Zcashd Team Apr 13, 2018

@str4d str4d requested review from bitcartel and daira Apr 13, 2018

@str4d

This comment has been minimized.

Contributor

str4d commented Apr 13, 2018

@zkbot try

@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 13, 2018

⌛️ Trying commit 47fe5f7 with merge 3b34f4a...

zkbot added a commit that referenced this pull request Apr 13, 2018

Auto merge of #3153 - str4d:default-disable-libs, r=<try>
Disable building libzcashconsensus by default

The library is not currently a supported build artifact; it needs work in
order to build on certain platforms (e.g. MacOS), and its dependencies need to
be narrowed down (Equihash is not a requirement for validating scripts).
@str4d

This comment has been minimized.

Contributor

str4d commented Apr 13, 2018

MacOS builds with this PR! https://ci.z.cash/#/builders/16/builds/254

And the next failure should be fixed by #2784.

@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 14, 2018

☀️ Test successful - pr-try
State: approved= try=True

@daira

daira approved these changes Apr 14, 2018

utACK

@ebfull

ebfull approved these changes Apr 14, 2018

@str4d str4d removed the request for review from bitcartel Apr 14, 2018

@str4d

This comment has been minimized.

Contributor

str4d commented Apr 14, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 14, 2018

📌 Commit 47fe5f7 has been approved by str4d

zkbot added a commit that referenced this pull request Apr 14, 2018

Auto merge of #3153 - str4d:default-disable-libs, r=str4d
Disable building libzcashconsensus by default

The library is not currently a supported build artifact; it needs work in
order to build on certain platforms (e.g. MacOS), and its dependencies need to
be narrowed down (Equihash is not a requirement for validating scripts).
@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 14, 2018

⌛️ Testing commit 47fe5f7 with merge 8be9d79...

@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 14, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 8be9d79 to master...

@zkbot zkbot merged commit 47fe5f7 into zcash:master Apr 14, 2018

1 check passed

homu Test successful
Details

@str4d str4d moved this from Implemented — Waiting for ACKs to Complete in Zcashd Team Apr 14, 2018

@str4d str4d deleted the str4d:default-disable-libs branch Apr 14, 2018

@str4d str4d referenced this pull request Apr 15, 2018

Closed

Build on Mac OS X #2246

@mdr0id mdr0id moved this from Complete to Released (Merged in Master) in Zcashd Team Apr 17, 2018

str4d added a commit to str4d/zcash that referenced this pull request May 22, 2018

zkbot added a commit that referenced this pull request May 22, 2018

Auto merge of #3286 - str4d:3153-gitian-fix, r=str4d
Comment out Gitian library handling while we don't build any libraries

Fixes a Gitian build failure introduced by #3153.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment