New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Sapling testnet parameters into memory #3185

Merged
merged 2 commits into from Apr 20, 2018

Conversation

@ebfull
Contributor

ebfull commented Apr 17, 2018

This PR depends on zcash/librustzcash#4.

The parameters are not loaded into memory if zcashd is configured as a mainnet node -- this is something we can change in the weeks before 2.0.0.

@ebfull

This comment has been minimized.

Contributor

ebfull commented Apr 17, 2018

By the way, the testnet parameters were generated by @str4d and I on our laptops, so they're a product of the MPC code.

@str4d

utACK, but the librustzcash commit needs to be updated before merging. I will test this once parameters are uploaded.

@str4d str4d added this to In Review in Consensus Protocol Team Apr 18, 2018

@str4d

str4d approved these changes Apr 19, 2018

Tested ACK.

@daira

daira approved these changes Apr 19, 2018

utACK

@str4d

This comment has been minimized.

Contributor

str4d commented Apr 20, 2018

@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 20, 2018

📌 Commit 62ba80e has been approved by str4d

@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 20, 2018

⌛️ Testing commit 62ba80e with merge 515b937...

zkbot added a commit that referenced this pull request Apr 20, 2018

Auto merge of #3185 - ebfull:sapling-testnet-params, r=str4d
Load Sapling testnet parameters into memory

This PR depends on zcash/librustzcash#4.

The parameters are not loaded into memory if `zcashd` is configured as a mainnet node -- this is something we can change in the weeks before `2.0.0`.
@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 20, 2018

💔 Test failed - pr-merge

@str4d

This comment has been minimized.

Contributor

str4d commented Apr 20, 2018

@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 20, 2018

⌛️ Testing commit 62ba80e with merge 5821bb0...

zkbot added a commit that referenced this pull request Apr 20, 2018

Auto merge of #3185 - ebfull:sapling-testnet-params, r=str4d
Load Sapling testnet parameters into memory

This PR depends on zcash/librustzcash#4.

The parameters are not loaded into memory if `zcashd` is configured as a mainnet node -- this is something we can change in the weeks before `2.0.0`.
@zkbot

This comment has been minimized.

Contributor

zkbot commented Apr 20, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 5821bb0 to master...

@zkbot zkbot merged commit 62ba80e into zcash:master Apr 20, 2018

1 check passed

homu Test successful
Details

Consensus Protocol Team automation moved this from In Review to Complete PRs (Ignore) Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment