Bech32 encoding support #3202

str4d · 2018-04-23T22:04:38Z

Cherry-picked from the following upstream PRs:

[test] Remove unused code bitcoin/bitcoin#8578
Full BIP173 (Bech32) support bitcoin/bitcoin#11167
- Only the second and third commits (first is in Refactor t-address encoding #3228, fourth depends on Misc upstream PRs #2390, later ones are SegWit-specific).
Clarify include guard naming convention bitcoin/bitcoin#12757
- Only the change to src/bech32.h

Part of #3058.

str4d · 2018-04-23T22:53:34Z

zkbot · 2018-04-23T22:53:40Z

⌛ Trying commit 1f6f5a2 with merge 2c1f65d...

Bech32 encoding support and t-addr encoding refactor Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7922 - bitcoin/bitcoin#7825 - bitcoin/bitcoin#8317 - bitcoin/bitcoin#9804 - Only the commit that changed `base58.cpp` - bitcoin/bitcoin#11117 - bitcoin/bitcoin#11259 - bitcoin/bitcoin#11167 - Only the first three commits (the fourth commit depends on #2390, later ones are SegWit-specific). Part of #3058.

zkbot · 2018-04-24T01:52:44Z

☀️ Test successful - pr-try
State: approved= try=True

str4d · 2018-04-24T21:47:38Z

Updated PR so that it now contains both the CBitcoinAddress and CBitcoinSecret refactors.

@zkbot try

zkbot · 2018-04-24T21:47:43Z

⌛ Trying commit 2219e6f with merge 1c2f24793b665e4b56a85e6eebabc40b7a59e554...

zkbot · 2018-04-25T00:25:40Z

☀️ Test successful - pr-try
State: approved= try=True

str4d · 2018-04-25T11:29:35Z

Implemented the changes to remove CZCEncoding, and then pulled in the remaining upstream changes to clean up transparent address encoding.

@zkbot try

zkbot · 2018-04-25T11:29:41Z

⌛ Trying commit ebf0745 with merge d5b558ba5be0186b049bbc764139e50fa059e72b...

zkbot · 2018-04-25T11:46:16Z

💔 Test failed - pr-try

str4d · 2018-04-25T12:01:50Z

Missed some includes in Zcash-specific code; pushed a commit to fix.

@zkbot try

zkbot · 2018-04-25T12:01:55Z

⌛ Trying commit cb13473 with merge 962ba99b3658005a16711eb2a11fd30a5ea94a05...

zkbot · 2018-04-25T13:52:47Z

💔 Test failed - pr-try

str4d · 2018-04-25T14:08:45Z

Transient failure in one of the RPC tests.

bitcartel · 2018-05-07T23:37:18Z

@zkbot try

zkbot · 2018-05-07T23:37:23Z

⌛ Trying commit 768cd14 with merge 19ac942...

Bech32 encoding support Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#8578 - bitcoin/bitcoin#11167 - Only the second and third commits (first is in #3228, fourth depends on #2390, later ones are SegWit-specific). - bitcoin/bitcoin#12757 - Only the change to `src/bech32.h` Part of #3058.

str4d · 2018-05-07T23:45:43Z

I'm gonna interrupt the try above, as we've already run one (modulo the merge conflict rebase), and any information the try would add to the two ACKs can be gleaned from the merge CI suite without the extra 1.5 hours.

zkbot · 2018-05-07T23:51:51Z

💔 Test failed - pr-try

str4d · 2018-05-07T23:52:13Z

@zkbot r+

zkbot · 2018-05-07T23:52:13Z

📌 Commit 768cd14 has been approved by str4d

zkbot · 2018-05-07T23:52:18Z

⌛ Testing commit 768cd14 with merge 42037a9b35a3543d97c01343b6c6987117135f47...

zkbot · 2018-05-08T01:14:35Z

💔 Test failed - pr-merge

bitcartel · 2018-05-08T01:58:31Z

Build error, nullifier test time out.

Tests successful
--- Success: wallet_overwintertx.py ---
=== Running testscript wallet_nullifiers.py ===
command timed out: 1200 seconds without output running ['./qa/zcash/full_test_suite.py', 'rpc'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=3088.330927

str4d · 2018-05-08T08:12:47Z

Yeah, transient failures (AWS-related likely).

@zkbot retry p=1

zkbot · 2018-05-08T08:18:12Z

⌛ Testing commit 768cd14 with merge c31718fea2d983d0021914c8b77de60b80a80d45...

zkbot · 2018-05-08T09:50:00Z

💔 Test failed - pr-merge

str4d · 2018-05-08T10:07:35Z

Transient failure. @zkbot retry

…

On Tue, 8 May 2018, 10:50 AM Homu, ***@***.***> wrote: 💔 Test failed - pr-merge <https://ci.z.cash/#builders/3/builds/298> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3202 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEwzB1g8rpPYui_6KTrU1llMXx_wmKl9ks5twWpOgaJpZM4Tgsec> .

zkbot · 2018-05-08T11:26:17Z

⌛ Testing commit 768cd14 with merge 01b1962cb60b23e936d5607d37d591d2878de704...

zkbot · 2018-05-08T13:02:15Z

💔 Test failed - pr-merge

str4d · 2018-05-08T13:05:06Z

Another transient hang in one of the EC2 workers 😠

@zkbot retry

zkbot · 2018-05-08T16:08:40Z

⌛ Testing commit 768cd14 with merge b1d2a69...

Bech32 encoding support Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#8578 - bitcoin/bitcoin#11167 - Only the second and third commits (first is in #3228, fourth depends on #2390, later ones are SegWit-specific). - bitcoin/bitcoin#12757 - Only the change to `src/bech32.h` Part of #3058.

zkbot · 2018-05-08T17:43:00Z

☀️ Test successful - pr-merge
Approved by: str4d
Pushing b1d2a69 to master...

Refactor t-address encoding Includes code cherry-picked from the following upstream PRs: - bitcoin/bitcoin#11117 - bitcoin/bitcoin#11259 - Only the second commit (first is for QT code) - bitcoin/bitcoin#11167 - Only the first commit (the rest are not part of the t-address encoding refactor). Part of zcash#3058. Precursor to zcash#3202.

str4d requested review from bitcartel and mdr0id April 23, 2018 22:07

str4d added the External Encoding label Apr 23, 2018

str4d added this to the v1.1.1 milestone Apr 23, 2018

str4d changed the title ~~3058 sapling bech32~~ Bech32 encoding support Apr 23, 2018

str4d changed the title ~~Bech32 encoding support~~ Bech32 encoding support and t-addr encoding refactor Apr 23, 2018

str4d added C-upstream-port Category: Changes that are ported from the Bitcoin Core codebase. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Apr 23, 2018

str4d added this to Implemented — Waiting for ACKs in Arborist Team Apr 23, 2018

str4d mentioned this pull request Apr 24, 2018

Make SpendingKey and PaymentAddress classes polymorphic to support Sprout, Sapling, and future types of addresses #3204

Closed

str4d changed the title ~~Bech32 encoding support and t-addr encoding refactor~~ Bech32 encoding support and address encoding refactor Apr 25, 2018

str4d mentioned this pull request Apr 26, 2018

Upstream encoding cleanups #3213

Merged

str4d moved this from In Review to In Progress in Arborist Team Apr 26, 2018

str4d mentioned this pull request May 8, 2018

Change JSOutPoint constructor to have js argument be uint64_t #3236

Merged

zkbot merged commit 768cd14 into zcash:master May 8, 2018

Arborist Team automation moved this from In Review to Released (Merged in Master) May 8, 2018

str4d mentioned this pull request May 8, 2018

Key encoding refactor #3242

Merged

str4d deleted the 3058-sapling-bech32 branch June 7, 2018 05:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bech32 encoding support #3202

Bech32 encoding support #3202

str4d commented Apr 23, 2018 •

edited

str4d commented Apr 23, 2018

zkbot commented Apr 23, 2018

zkbot commented Apr 24, 2018

str4d commented Apr 24, 2018

zkbot commented Apr 24, 2018

zkbot commented Apr 25, 2018

str4d commented Apr 25, 2018

zkbot commented Apr 25, 2018

zkbot commented Apr 25, 2018

str4d commented Apr 25, 2018

zkbot commented Apr 25, 2018

zkbot commented Apr 25, 2018

str4d commented Apr 25, 2018

bitcartel commented May 7, 2018

zkbot commented May 7, 2018

str4d commented May 7, 2018 •

edited

zkbot commented May 7, 2018

str4d commented May 7, 2018

zkbot commented May 7, 2018

zkbot commented May 7, 2018

zkbot commented May 8, 2018

bitcartel commented May 8, 2018

str4d commented May 8, 2018

zkbot commented May 8, 2018

zkbot commented May 8, 2018

str4d commented May 8, 2018 via email

zkbot commented May 8, 2018

zkbot commented May 8, 2018

str4d commented May 8, 2018

zkbot commented May 8, 2018

zkbot commented May 8, 2018

Bech32 encoding support #3202

Bech32 encoding support #3202

Conversation

str4d commented Apr 23, 2018 • edited

str4d commented Apr 23, 2018

zkbot commented Apr 23, 2018

zkbot commented Apr 24, 2018

str4d commented Apr 24, 2018

zkbot commented Apr 24, 2018

zkbot commented Apr 25, 2018

str4d commented Apr 25, 2018

zkbot commented Apr 25, 2018

zkbot commented Apr 25, 2018

str4d commented Apr 25, 2018

zkbot commented Apr 25, 2018

zkbot commented Apr 25, 2018

str4d commented Apr 25, 2018

bitcartel commented May 7, 2018

zkbot commented May 7, 2018

str4d commented May 7, 2018 • edited

zkbot commented May 7, 2018

str4d commented May 7, 2018

zkbot commented May 7, 2018

zkbot commented May 7, 2018

zkbot commented May 8, 2018

bitcartel commented May 8, 2018

str4d commented May 8, 2018

zkbot commented May 8, 2018

zkbot commented May 8, 2018

str4d commented May 8, 2018 via email

zkbot commented May 8, 2018

zkbot commented May 8, 2018

str4d commented May 8, 2018

zkbot commented May 8, 2018

zkbot commented May 8, 2018

str4d commented Apr 23, 2018 •

edited

str4d commented May 7, 2018 •

edited