New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consensus rules about the number of Spend and Output Descriptions in a transaction #3220

Merged
merged 2 commits into from May 1, 2018

Conversation

@Eirik0
Contributor

Eirik0 commented Apr 26, 2018

Closes #3209.
Part of #3065.

@Eirik0 Eirik0 self-assigned this Apr 26, 2018

@Eirik0

This comment has been minimized.

Contributor

Eirik0 commented Apr 26, 2018

See #3065

@ebfull

This comment has been minimized.

Contributor

ebfull commented Apr 27, 2018

ACK

@ebfull

ebfull approved these changes Apr 30, 2018

@str4d str4d added this to In Review in Consensus Protocol Team May 1, 2018

@str4d str4d added this to the v1.1.1 milestone May 1, 2018

@str4d str4d referenced this pull request May 1, 2018

Closed

Implement Sapling consensus rules #3065

25 of 25 tasks complete

@str4d str4d changed the title from 3209 fix check transaction to Implement consensus rules about the number of Spend and Output Descriptions May 1, 2018

@str4d

str4d approved these changes May 1, 2018

ut(ACK+cov)

@str4d str4d changed the title from Implement consensus rules about the number of Spend and Output Descriptions to Implement consensus rules about the number of Spend and Output Descriptions in a transaction May 1, 2018

@str4d

This comment has been minimized.

Contributor

str4d commented May 1, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Contributor

zkbot commented May 1, 2018

📌 Commit 8120982 has been approved by str4d

@str4d

This comment has been minimized.

Contributor

str4d commented May 1, 2018

@zkbot p=1

@zkbot

This comment has been minimized.

Contributor

zkbot commented May 1, 2018

⌛️ Testing commit 8120982 with merge 0a8d0c2...

zkbot added a commit that referenced this pull request May 1, 2018

Auto merge of #3220 - Eirik0:3209-fix-CheckTransaction, r=str4d
Implement consensus rules about the number of Spend and Output Descriptions in a transaction

Closes #3209.
Part of #3065.
@zkbot

This comment has been minimized.

Contributor

zkbot commented May 1, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 0a8d0c2 to master...

@zkbot zkbot merged commit 8120982 into zcash:master May 1, 2018

1 check passed

homu Test successful
Details

Consensus Protocol Team automation moved this from In Review to Complete PRs (Ignore) May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment