Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Sapling validation #3232
I just made a change that considerably reduces the diff.
Thus, no need for extra nesting, and it looks cleaner.
Some questions about error handling when calling librustzcash.
What if rust panics, which could occur here:
What kind of C++ exception gets thrown? Should it be caught?
Basically, is there a situation where
librustzcash_sapling_verification_ctx_free(ctx); fails to be invoked if the librustzcash call fails?
On Thu, 10 May 2018, 1:01 PM Eirik Ogilvie-Wigley, ***@***.***> wrote: utACK — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3232 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEwzB4QnbJHl3d79-HPznV-qnYY8Y_9Kks5txHJrgaJpZM4Tum2_> .