New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify help that signmessage only works on taddrs #3259

Merged
merged 1 commit into from Jun 22, 2018

Conversation

@leto
Copy link
Contributor

leto commented May 11, 2018

No description provided.

@ebfull

This comment has been minimized.

Copy link
Contributor

ebfull commented May 14, 2018

Yeah. Actually we will be able to support these signatures for Sapling z-addrs eventually. :)

@bitcartel bitcartel self-assigned this May 14, 2018

@bitcartel bitcartel added this to the v1.1.1 milestone May 14, 2018

@bitcartel bitcartel added this to Work Queue in User Support May 14, 2018

@str4d str4d modified the milestones: v1.1.1, v2.0.0 May 25, 2018

@mdr0id mdr0id added this to Product Backlog in Zcashd Team Jun 7, 2018

@ioptio ioptio added the usi label Jun 18, 2018

@str4d

str4d approved these changes Jun 22, 2018

Copy link
Contributor

str4d left a comment

ACK. Thanks for this!

@str4d

This comment has been minimized.

Copy link
Contributor

str4d commented Jun 22, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 22, 2018

📌 Commit 30bf78c has been approved by str4d

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 22, 2018

⌛️ Testing commit 30bf78c with merge f587e61...

zkbot added a commit that referenced this pull request Jun 22, 2018

Auto merge of #3259 - leto:signmessage, r=str4d
Clarify help that signmessage only works on taddrs

@str4d str4d moved this from Product Backlog to In Review in Zcashd Team Jun 22, 2018

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 22, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing f587e61 to master...

@zkbot zkbot merged commit 30bf78c into zcash:master Jun 22, 2018

1 check passed

homu Test successful
Details

User Support automation moved this from Work Queue to Merged Jun 22, 2018

Zcashd Team automation moved this from In Review to Released (Merged in Master) Jun 22, 2018

@ioptio ioptio moved this from Merged to Complete in User Support Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment