New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test vectors for sapling key components #3332

Merged
merged 1 commit into from Jun 13, 2018

Conversation

@arcalinea
Copy link
Contributor

arcalinea commented Jun 13, 2018

Test vectors generated by python implementation here: zcash-hackworks/zcash-test-vectors#4

Not testing note components in this PR

@arcalinea arcalinea requested a review from str4d Jun 13, 2018

@arcalinea arcalinea self-assigned this Jun 13, 2018

@arcalinea arcalinea requested a review from bitcartel Jun 13, 2018

@arcalinea arcalinea force-pushed the arcalinea:sapling_wallet_classes branch from eda4adc to 96813cc Jun 13, 2018

@str4d

str4d approved these changes Jun 13, 2018

Copy link
Contributor

str4d left a comment

utACK. Squash the commits if you have time 🙂

@str4d str4d added the testing label Jun 13, 2018

@str4d str4d added this to the v2.0.0 milestone Jun 13, 2018

@str4d str4d added this to In Review in Zcashd Team Jun 13, 2018

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Jun 13, 2018

@arcalinea Squash commits before merge?

@bitcartel bitcartel force-pushed the arcalinea:sapling_wallet_classes branch from 96813cc to 052d640 Jun 13, 2018

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Jun 13, 2018

I squashed and pushed to the PR. Git log shows author has been preserved.

commit 052d640cb0e339a20a0e5fdc8394200537b33f45
Author: Jay Graber <jay@z.cash>
Date:   Tue Jun 12 11:58:58 2018 -0700

    Add json test vectors for Sapling key components.
@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Jun 13, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 13, 2018

📌 Commit 052d640 has been approved by bitcartel

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 13, 2018

⌛️ Testing commit 052d640 with merge 3e38e24...

zkbot added a commit that referenced this pull request Jun 13, 2018

Auto merge of #3332 - arcalinea:sapling_wallet_classes, r=bitcartel
Add test vectors for sapling key components

Test vectors generated by python implementation here: zcash-hackworks/zcash-test-vectors#4

Not testing note components in this PR

@bitcartel bitcartel moved this from In Review to Released (Merged in Master) in Zcashd Team Jun 13, 2018

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 13, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 3e38e24 to master...

@zkbot zkbot merged commit 052d640 into zcash:master Jun 13, 2018

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment