New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashFinalSaplingRoot to getblockheader and getblock output #3337

Merged
merged 1 commit into from Jun 20, 2018

Conversation

5 participants
@str4d
Copy link
Contributor

str4d commented Jun 15, 2018

No description provided.

@str4d str4d added the RPC interface label Jun 15, 2018

@str4d str4d added this to the v1.1.2 milestone Jun 15, 2018

@str4d str4d added this to In Review in Zcashd Team Jun 15, 2018

@bitcartel
Copy link
Contributor

bitcartel left a comment

Should the help message include a comment about what a null value represents e.g. pre-sapling block?

@mdr0id mdr0id self-requested a review Jun 19, 2018

@mdr0id

mdr0id approved these changes Jun 19, 2018

Copy link
Contributor

mdr0id left a comment

ACK

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Jun 19, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 19, 2018

📌 Commit 3af4633 has been approved by bitcartel

@bitcartel bitcartel moved this from In Review to Released (Merged in Master) in Zcashd Team Jun 19, 2018

@daira

daira approved these changes Jun 19, 2018

Copy link
Contributor

daira left a comment

Post-hoc ACK, but please file a ticket to add a test.

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Jun 19, 2018

Ticket filed.

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 19, 2018

⌛️ Testing commit 3af4633 with merge f24d1ff...

zkbot added a commit that referenced this pull request Jun 19, 2018

Auto merge of #3337 - str4d:getblock-finalsaplingroot, r=bitcartel
Add hashFinalSaplingRoot to getblockheader and getblock output
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 20, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing f24d1ff to master...

@zkbot zkbot merged commit 3af4633 into zcash:master Jun 20, 2018

1 check passed

homu Test successful
Details

@str4d str4d deleted the str4d:getblock-finalsaplingroot branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment