Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support testnet rollback. #3443
I synced testnet and reindexed a couple of times and did not notice anything out of the ordinary.
Regarding @str4d's comment on the startup log noise. I was not seeing this in the logs - certainly not nearly as much as I was seeing logs from UpdateTip, e.g.,
which is logged incessantly.
Also, this may be a silly question, or overly complicated to do, but would it make sense to try to update
I was referring to when no reindex is required on startup. If a reindex is required, then yes there will be noise from
It's impossible, because the RPC tests use regtest mode, while the changes solely affect testnet. Even if we worked around that, we can't recreate the exact desired hash in regtest anyway as we can't (yet) break SHA256d.
added a commit
this pull request
Aug 8, 2018
Aug 8, 2018
1 check passed
We could test it by adding a general mechanism to set long-rollback exceptions from tests, in the same way that we can set network upgrade activations from tests. I'm not sure it's worth the complexity.