New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Sapling mainnet activation height #3469

Merged
merged 1 commit into from Aug 16, 2018

Conversation

@ebfull
Copy link
Contributor

ebfull commented Aug 15, 2018

In mainnet, block #419200 is expected to appear on October 28, 2018, Zcash's birthday.

In testnet, block #280000 is expected about a week from now. (Current height is ~275249, plus 4032 blocks for a week, plus a little more just to make the number nice.)

These are the activation heights for Sapling in mainnet and testnet, respectively. Protocol version is also changed.

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Aug 15, 2018

Protocol version for sapling testnet doesnt match mainnet?

@bitcartel bitcartel added this to the v2.0.0 milestone Aug 15, 2018

@bitcartel bitcartel added Sapling and removed networking labels Aug 15, 2018

@str4d str4d added this to In Review in Zcashd Team Aug 15, 2018

@str4d
Copy link
Contributor

str4d left a comment

Add the following text (or something similar) to doc/release-notes.md:

Sapling network upgrade
-----------------------

The activation height for the Sapling network upgrade on mainnet is included
in this release. Sapling will activate on mainnet at height 419000, which is
expected to be mined on the 28th of October 2018. Please upgrade to this release,
or any subsequent release, in order to follow the Sapling network upgrade.

The testnet is being rolled back in this release to Overwinter. Sapling will
activate on testnet at height 280000, which is expected to be mined in about a
week. Please update your testnet nodes before then.
@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Aug 15, 2018

I would remove "which is expected to be mined in about a week. Please update your testnet nodes before then." since its relative to when someone reads the release notes. Just stating that Sapling activates at 280000 should suffice.

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Aug 15, 2018

Please squash into one commit.

@ebfull ebfull force-pushed the ebfull:sapling-mainnet-activation branch from b7b8f49 to 955b328 Aug 15, 2018

@ebfull

This comment has been minimized.

Copy link
Contributor

ebfull commented Aug 15, 2018

Squashed and added those notes. I also changed the activation height to 419200 which may be more convenient if there's an emergency.

@str4d

str4d approved these changes Aug 15, 2018

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Aug 15, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Aug 15, 2018

📌 Commit 955b328 has been approved by bitcartel

zkbot added a commit that referenced this pull request Aug 15, 2018

Auto merge of #3469 - ebfull:sapling-mainnet-activation, r=bitcartel
Set Sapling mainnet activation height

In mainnet, block #419200 is expected to appear on October 28, 2018, Zcash's birthday.

In testnet, block #280000 is expected about a week from now. (Current height is ~275249, plus 4032 blocks for a week, plus a little more just to make the number nice.)

These are the activation heights for Sapling in mainnet and testnet, respectively. Protocol version is also changed.
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Aug 15, 2018

⌛️ Testing commit 955b328 with merge 9c004ee...

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Aug 15, 2018

💔 Test failed - pr-merge

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Aug 15, 2018

@ebfull Transient failure... @Eirik0 wallet_changeindicator test...

@zkbot retry

zkbot added a commit that referenced this pull request Aug 15, 2018

Auto merge of #3469 - ebfull:sapling-mainnet-activation, r=bitcartel
Set Sapling mainnet activation height

In mainnet, block #419200 is expected to appear on October 28, 2018, Zcash's birthday.

In testnet, block #280000 is expected about a week from now. (Current height is ~275249, plus 4032 blocks for a week, plus a little more just to make the number nice.)

These are the activation heights for Sapling in mainnet and testnet, respectively. Protocol version is also changed.
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Aug 15, 2018

⌛️ Testing commit 955b328 with merge 4f82feb...

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Aug 16, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 4f82feb to master...

@zkbot zkbot merged commit 955b328 into zcash:master Aug 16, 2018

1 check passed

homu Test successful
Details

Zcashd Team automation moved this from In Review to Released (Merged in Master) Aug 16, 2018

@daira
Copy link
Contributor

daira left a comment

Post-hoc utACK.

Note that there's still a stale comment at

// Find any nodes which don't support Overwinter protocol version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment