Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Sapling support to z_shieldcoinbase #3518
added a commit
this pull request
Sep 13, 2018
@str4d When letting the user choose "no limit" for the number of utxos to shield, we get bad sigops.
Here is a tx shielding 1000 coinbase utxos:
From trial and error, the most I got to work was 1333 coinbase utxos. That created a transaction which was accepted into the local mempool, but it was never mined.
It seems the transaction was rejected because the default fee of 0.0001 I specified was too low given the size of the transaction, so it was treated as "free", probably like the earlier transaction. In
Here is a tx shielding 1333 coinbase utxos:
To follow up, the sigops error appears with sprout zaddr too.
The 4000 limit mentioned in the log is inherited from upsteam:
The above sigops bug should be handled in a separate PR, as it is not directly caused by this PR (just maintained with Sapling), and can be circumvented by users in the short term by specifying a concrete maximum instead of zero.
I pushed a commit to address @Eirik0's comment.