New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3467. Add benchmarks for Sapling spends and outputs. #3611

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@bitcartel
Copy link
Contributor

bitcartel commented Oct 18, 2018

Four new benchmarks are added to RPC zcbenchmark:

  • createsaplingspend
  • createsaplingoutput
  • verifysaplingspend
  • verifysaplingoutput

@bitcartel bitcartel added this to the v2.0.2 milestone Oct 18, 2018

@bitcartel bitcartel self-assigned this Oct 18, 2018

@bitcartel bitcartel requested review from ebfull , str4d and mdr0id Oct 18, 2018

@bitcartel bitcartel added this to In Review in Zcashd Team Oct 18, 2018

@Eirik0 Eirik0 self-requested a review Oct 18, 2018

Show resolved Hide resolved src/zcbenchmarks.cpp Outdated
Closes #3467. Add benchmarks for Sapling spends and outputs.
Four new benchmarks are added to RPC zcbenchmark:
- createsaplingspend
- createsaplingoutput
- verifysaplingspend
- verifysaplingoutput

@bitcartel bitcartel force-pushed the bitcartel:3467_add_sapling_benchmarks branch from face5e4 to 67d2b79 Oct 19, 2018

@Eirik0

Eirik0 approved these changes Oct 19, 2018

Copy link
Contributor

Eirik0 left a comment

ACK

@mdr0id

mdr0id approved these changes Oct 22, 2018

Copy link
Contributor

mdr0id left a comment

utACK

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Oct 23, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 23, 2018

📌 Commit 67d2b79 has been approved by bitcartel

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 23, 2018

⌛️ Testing commit 67d2b79 with merge d67b21d...

zkbot added a commit that referenced this pull request Oct 23, 2018

Auto merge of #3611 - bitcartel:3467_add_sapling_benchmarks, r=bitcartel
Closes #3467. Add benchmarks for Sapling spends and outputs.

Four new benchmarks are added to RPC zcbenchmark:
- createsaplingspend
- createsaplingoutput
- verifysaplingspend
- verifysaplingoutput
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 23, 2018

💔 Test failed - pr-merge

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Oct 24, 2018

Transient failure. Trying again. @zkbot retry

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 24, 2018

⌛️ Testing commit 67d2b79 with merge dc3398f...

zkbot added a commit that referenced this pull request Oct 24, 2018

Auto merge of #3611 - bitcartel:3467_add_sapling_benchmarks, r=bitcartel
Closes #3467. Add benchmarks for Sapling spends and outputs.

Four new benchmarks are added to RPC zcbenchmark:
- createsaplingspend
- createsaplingoutput
- verifysaplingspend
- verifysaplingoutput
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 24, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing dc3398f to master...

@zkbot zkbot merged commit 67d2b79 into zcash:master Oct 24, 2018

1 check passed

homu Test successful
Details

Zcashd Team automation moved this from In Review to Released (Merged in Master) Oct 24, 2018

@arielgabizon

This comment has been minimized.

Copy link
Contributor

arielgabizon commented Oct 25, 2018

Should these also be added somehow to performance-measurements.sh?
To run them right now do I need to start a zcashd myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment