New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3329. Send alert to put non-Sapling nodes into safe mode. #3628

Merged
merged 1 commit into from Oct 28, 2018

Conversation

@bitcartel
Contributor

bitcartel commented Oct 25, 2018

The alert targets nodes running protocol version <= 170006.
Sapling compatible nodes run protocol version >= 170007.

Closes #3329. Send alert to put non-Sapling nodes into safe mode.
The alert targets nodes running protocol version <= 170006.
Sapling compatible nodes run protocol version >= 170007.

@bitcartel bitcartel added this to the v2.0.2 milestone Oct 25, 2018

@bitcartel bitcartel self-assigned this Oct 25, 2018

@bitcartel bitcartel requested review from daira, ebfull and str4d Oct 25, 2018

@bitcartel bitcartel added this to In Review in Zcashd Team Oct 25, 2018

@daira

daira approved these changes Oct 25, 2018

utACK

@daira

This comment has been minimized.

Contributor

daira commented Oct 25, 2018

Also checked consistency with the update to https://github.com/zcash/zcash/wiki/specification#assigned-numbers .

@mdr0id

mdr0id approved these changes Oct 27, 2018 edited

utACK

@str4d

str4d approved these changes Oct 27, 2018

utACK

@ebfull

This comment has been minimized.

Contributor

ebfull commented Oct 27, 2018

utACK

@ebfull ebfull removed their request for review Oct 27, 2018

@ebfull

ebfull approved these changes Oct 27, 2018

@daira

This comment has been minimized.

Contributor

daira commented Oct 28, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Collaborator

zkbot commented Oct 28, 2018

📌 Commit fa46ab1 has been approved by daira

@zkbot

This comment has been minimized.

Collaborator

zkbot commented Oct 28, 2018

⌛️ Testing commit fa46ab1 with merge aee5072...

zkbot added a commit that referenced this pull request Oct 28, 2018

Auto merge of #3628 - bitcartel:3329_safe_mode_alert_for_pre_sapling_…
…nodes, r=daira

Closes #3329. Send alert to put non-Sapling nodes into safe mode.

The alert targets nodes running protocol version <= 170006.
Sapling compatible nodes run protocol version >= 170007.
@zkbot

This comment has been minimized.

Collaborator

zkbot commented Oct 28, 2018

☀️ Test successful - pr-merge
Approved by: daira
Pushing aee5072 to master...

@zkbot zkbot merged commit fa46ab1 into zcash:master Oct 28, 2018

1 check passed

homu Test successful
Details

Zcashd Team automation moved this from In Review to Released (Merged in Master) Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment