New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEC-013 mitigation #3689

Merged
merged 6 commits into from Nov 17, 2018

Conversation

3 participants
@bitcartel
Copy link
Contributor

bitcartel commented Nov 17, 2018

No description provided.

bitcartel added some commits Nov 7, 2018

For ZEC-013. Mitigate potential tx expiry height related DoS vector.
Don't accept transactions which are about to expire (next 3 blocks).
Don't set a ban score if a peer does propragate these transactions.
See ZEC-013 for more detail.
For ZEC-013. Don't propagate txs which are expiring soon in p2p messa…
…ges.

When responding to "mempool" message, do not include the txid of an
expiring soon transaction in the "inv" message reply.
When responding to "getdata" message, do not reply with a "tx" message
for a transaction which is expiring soon.

@bitcartel bitcartel added this to the v2.0.2 milestone Nov 17, 2018

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Nov 17, 2018

This PR was reviewed by @defuse @arielgabizon and also reviewed and ACKed by @daira @str4d @Eirik0

@bitcartel

This comment has been minimized.

Copy link
Contributor

bitcartel commented Nov 17, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Nov 17, 2018

📌 Commit 6d154ac has been approved by bitcartel

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Nov 17, 2018

⌛️ Testing commit 6d154ac with merge dfc2b33...

zkbot added a commit that referenced this pull request Nov 17, 2018

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Nov 17, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing dfc2b33 to master...

@zkbot zkbot merged commit 6d154ac into zcash:master Nov 17, 2018

1 check passed

homu Test successful
Details

@zkbot zkbot added this to Released (Merged in Master) in Zcashd Team via automation Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment