Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting logo on README #3846

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@garethtdavies
Copy link
Contributor

commented Feb 20, 2019

As a follow up to #3509 which I closed due to the updated branding. The logo [still has the wrong aspect ratio]. This corrects it with the logo taken from https://z.cash/press/ while preserving the original image dimensions and aspect ratio. I added it at 2x for retina displays.

@garethtdavies

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

Closed by #3819

@garethtdavies garethtdavies force-pushed the garethtdavies:updated-logo branch from aa64129 to 89606bc Feb 26, 2019

@garethtdavies

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

#3819 didn't fix aspect ratio issues. Youu can see how this PR looks here: https://github.com/garethtdavies/zcash/tree/updated-logo

@daira

daira approved these changes Mar 3, 2019

Copy link
Contributor

left a comment

ACK

@bitcartel bitcartel added this to Needs Prioritization in Arborist Team via automation Mar 19, 2019

@bitcartel bitcartel removed this from Needs Prioritization in Arborist Team Mar 19, 2019

@bitcartel

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

📌 Commit 89606bc has been approved by bitcartel

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

⌛️ Testing commit 89606bc with merge 8eb6101...

zkbot added a commit that referenced this pull request Mar 19, 2019

Auto merge of #3846 - garethtdavies:updated-logo, r=bitcartel
Correcting logo on README

As a follow up to #3509 which I closed due to the updated branding. The logo [still has the wrong aspect ratio]. This corrects it with the logo taken from https://z.cash/press/ while preserving the original image dimensions and aspect ratio. I added it at 2x for retina displays.
@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 8eb6101 to master...

@zkbot zkbot merged commit 89606bc into zcash:master Mar 19, 2019

1 check passed

homu Test successful
Details

@str4d str4d added this to the v2.0.4 milestone Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.