Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix enable-debug build DB_COINS undefined #3907

Merged
merged 1 commit into from Apr 9, 2019

Conversation

@LarryRuane
Copy link
Contributor

commented Mar 20, 2019

Fixes #3860. The way DB_COINS is defined in this PR is the same as in src/txdb.cpp (static "global" instead of class member).

@daira

daira approved these changes Mar 28, 2019

Copy link
Contributor

left a comment

utACK

@LarryRuane LarryRuane requested a review from Eirik0 Mar 28, 2019

@daira daira added bug build labels Apr 1, 2019

@daira daira added this to Needs Prioritization in Arborist Team via automation Apr 1, 2019

@leto

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

👍 , this bug blocks compiling a supported Zcash node on OS X. Versions which still compile are beyond their deprecation heights, so pushing this out sooner rather than later would be good.

@ioptio ioptio added the usi label Apr 8, 2019

@rex4539

rex4539 approved these changes Apr 9, 2019

@daira

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2019

📌 Commit e1df250 has been approved by daira

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2019

⌛️ Testing commit e1df250 with merge 3354814...

zkbot added a commit that referenced this pull request Apr 9, 2019

Auto merge of #3907 - LarryRuane:3860-enable-debug-build, r=daira
fix enable-debug build DB_COINS undefined

Fixes #3860. The way `DB_COINS` is defined in this PR is the same as in `src/txdb.cpp` (static "global" instead of class member).

@daira daira added the macOS label Apr 9, 2019

@str4d

str4d approved these changes Apr 9, 2019

Copy link
Contributor

left a comment

utACK

@str4d str4d added this to the v2.0.5 milestone Apr 9, 2019

@str4d str4d moved this from Needs Prioritization to Merge Queue in Arborist Team Apr 9, 2019

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2019

☀️ Test successful - pr-merge
Approved by: daira
Pushing 3354814 to master...

@zkbot zkbot merged commit e1df250 into zcash:master Apr 9, 2019

1 check passed

homu Test successful
Details

Arborist Team automation moved this from Merge Queue to Released (Merged in Master) Apr 9, 2019

@daira daira modified the milestones: v2.0.5, v2.0.4 Apr 16, 2019

@mms710 mms710 modified the milestones: v2.0.4, v2.0.5 Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.