Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Fix new HD seed generation for previously-encrypted wallets #3940

Merged

Conversation

4 participants
@str4d
Copy link
Contributor

commented Apr 4, 2019

Closes #3607.

How to verify (with zcashd flags -testnet -wallet=wallet.3607.dat -experimentalfeatures -developerencryptwallet):

  • Start zcashd 2.0.0, encrypt the wallet, and stop the node.
  • Start zcashd 2.0.1+ (before this branch), and see that it crashes during startup.
  • Start zcashd built from this branch, and see that it does not crash during startup. Unlock the wallet, then stop.
  • Start zcashd 2.0.1+ (before this branch), and see that it no longer crashes during startup.

@str4d str4d added bug wallet labels Apr 4, 2019

@str4d str4d added this to Needs Prioritization in Arborist Team via automation Apr 4, 2019

@str4d str4d requested review from bitcartel and mdr0id Apr 5, 2019

@str4d str4d moved this from Needs Prioritization to PRs That Need Review + Their Associated Issues in Arborist Team Apr 5, 2019

@daira

daira approved these changes Apr 7, 2019

Copy link
Contributor

left a comment

utACK, but I'd prefer to have a unit test for this.

@mms710 mms710 added this to Backlog in Ecosystem Team Apr 24, 2019

@bitcartel
Copy link
Contributor

left a comment

ACK. Reproduced the manual steps to confirm this PR fixes the issue of terminating upon launch with:

************************
EXCEPTION: St13runtime_error       
GenerateNewSeed: SetHDSeed failed       
Zcash in AppInit()    

@mms710 mms710 removed this from Backlog in Ecosystem Team Apr 25, 2019

@bitcartel bitcartel added this to the v2.0.5 milestone Apr 25, 2019

@bitcartel

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

📌 Commit 1f561f3 has been approved by bitcartel

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

⌛️ Testing commit 1f561f3 with merge 1fefed9...

zkbot added a commit that referenced this pull request Apr 25, 2019

Auto merge of #3940 - str4d:3607-init-encrypted-wallet-without-hd-see…
…d, r=bitcartel

init: Fix new HD seed generation for previously-encrypted wallets

Closes #3607.

How to verify (with `zcashd` flags `-testnet -wallet=wallet.3607.dat -experimentalfeatures -developerencryptwallet`):
- Start `zcashd` 2.0.0, encrypt the wallet, and stop the node.
- Start `zcashd` 2.0.1+ (before this branch), and see that it crashes during startup.
- Start `zcashd` built from this branch, and see that it does not crash during startup. Unlock the wallet, then stop.
- Start `zcashd` 2.0.1+ (before this branch), and see that it no longer crashes during startup.

@bitcartel bitcartel moved this from PRs That Need Review + Their Associated Issues to In Review in Arborist Team Apr 25, 2019

@bitcartel bitcartel moved this from In Review to Merge Queue in Arborist Team Apr 25, 2019

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 1fefed9 to master...

@zkbot zkbot merged commit 1f561f3 into zcash:master Apr 25, 2019

1 check passed

homu Test successful
Details

Arborist Team automation moved this from Merge Queue to Released (Merged in Master) Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.