Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Sprout -> Sapling migration status nullptr defence #3987
It was discovered that when calling
The second commit in the PR is defensive. We were concerned that storing the sapling migration async operation object could run into a race condition when trying to cancel it. The fix for this was to store the async operation's id rather than the operation itself, and then to go through the async rpc queue to recall, cancel, and remove migration operations which should not continue to execute.
As a note -