Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Logging and persist async operation for Sapling migration #4002
Currently zcashd will automatically remove the last async migration operations when it reaches the height where it sends the transactions it just made. This is not in alignment with other async operations, which are not removed until a node is restarted or a user calls
Documentation: none needed.
Suggestion, we can probably catch many of the
With this change, running the test (without Eirik's latest commit) generates the expected error:
The only downside is that more lines get written to the test's
I'd even suggest enabling all debug logging (for all RPC tests), and run the full test suite -- I bet we'd uncover many more of these format string bugs. I may just try that.