Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the use of 0 as expiryheight in createrawtransaction, to disable expiry #4134

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@daira
Copy link
Contributor

daira commented Sep 16, 2019

fixes #4132

@daira daira added this to the v2.1.0 milestone Sep 16, 2019
@daira daira added this to Needs Prioritization in Arborist Team via automation Sep 16, 2019
@daira daira requested review from str4d and charlieok Sep 16, 2019
@daira daira moved this from Needs Prioritization to PRs That Need Review + Their Associated Issues in Arborist Team Sep 16, 2019
@daira daira moved this from PRs That Need Review + Their Associated Issues to In Review in Arborist Team Sep 17, 2019
@str4d
str4d approved these changes Sep 17, 2019
Copy link
Contributor

str4d left a comment

utACK

Copy link
Contributor

charlieok left a comment

Makes sense to me. utACK.

@daira

This comment has been minimized.

Copy link
Contributor Author

daira commented Sep 18, 2019

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 18, 2019

📌 Commit c08603d has been approved by daira

@daira daira mentioned this pull request Sep 18, 2019
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 18, 2019

⌛️ Testing commit c08603d with merge b8ee381...

zkbot added a commit that referenced this pull request Sep 18, 2019
Fix the use of 0 as expiryheight in createrawtransaction, to disable expiry

fixes #4132
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 18, 2019

💔 Test failed - pr-merge

@daira

This comment has been minimized.

Copy link
Contributor Author

daira commented Sep 18, 2019

Unexplained failure on the kitchensink builder :-/

mv -f wallet/test/.deps/test_test_bitcoin-wallet_tests.Tpo wallet/test/.deps/test_test_bitcoin-wallet_tests.Po
Makefile:5235: recipe for target 'test/test_test_bitcoin-rpc_wallet_tests.o' failed
make[2]: *** [test/test_test_bitcoin-rpc_wallet_tests.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/admin/latent/debian8-kitchensink/build/src'

@zkbot retry

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 18, 2019

⌛️ Testing commit c08603d with merge 441b0fe...

zkbot added a commit that referenced this pull request Sep 18, 2019
Fix the use of 0 as expiryheight in createrawtransaction, to disable expiry

fixes #4132
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 18, 2019

💔 Test failed - pr-merge

@str4d

This comment has been minimized.

Copy link
Contributor

str4d commented Sep 23, 2019

We are holding off merging this until #4060 is merged (as this PR is simpler to re-review after a rebase).

@daira daira force-pushed the daira:fix-disable-expiry branch from c08603d to aeeaba6 Sep 25, 2019
daira added 2 commits Sep 16, 2019
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira force-pushed the daira:fix-disable-expiry branch from aeeaba6 to 3e37152 Sep 26, 2019
@Eirik0
Eirik0 approved these changes Sep 26, 2019
Copy link
Contributor

Eirik0 left a comment

utACK

@Eirik0

This comment has been minimized.

Copy link
Contributor

Eirik0 commented Sep 26, 2019

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 26, 2019

📌 Commit 3e37152 has been approved by Eirik0

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 26, 2019

⌛️ Testing commit 3e37152 with merge 8770f88...

zkbot added a commit that referenced this pull request Sep 26, 2019
Fix the use of 0 as expiryheight in createrawtransaction, to disable expiry

fixes #4132
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Sep 26, 2019

☀️ Test successful - pr-merge
Approved by: Eirik0
Pushing 8770f88 to master...

@zkbot zkbot merged commit 3e37152 into zcash:master Sep 26, 2019
1 check passed
1 check passed
homu Test successful
Details
Arborist Team automation moved this from In Review to Released (Merged in Master) Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Arborist Team
  
Released (Merged in Master)
5 participants
You can’t perform that action at this time.