Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends macOS: point --sysroot to SDK #4157

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@rex4539
Copy link
Contributor

rex4539 commented Oct 16, 2019

Fixes #4149
Fixes #4150
Fixes #4151
Fixes #4152

@Eirik0

This comment has been minimized.

Copy link
Contributor

Eirik0 commented Oct 23, 2019

@zkbot try

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 23, 2019

⌛️ Trying commit a80942f with merge 2688a20...

zkbot added a commit that referenced this pull request Oct 23, 2019
depends macOS: point --sysroot to SDK

Fixes #4149
Fixes #4150
Fixes #4151
Fixes #4152
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 23, 2019

☀️ Test successful - pr-try
State: approved= try=True

@daira
daira approved these changes Oct 24, 2019
Copy link
Contributor

daira left a comment

utACK modulo comment. I do not have a Catalina machine/VM to test on.

depends/builders/darwin.mk Show resolved Hide resolved
@daira

This comment has been minimized.

Copy link
Contributor

daira commented Oct 24, 2019

Note that this self-evidently can't break any platform other than macOS.

@daira daira added the macOS label Oct 24, 2019
@Eirik0
Eirik0 approved these changes Oct 24, 2019
Copy link
Contributor

Eirik0 left a comment

utACK

@Eirik0

This comment has been minimized.

Copy link
Contributor

Eirik0 commented Oct 24, 2019

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 24, 2019

📌 Commit a80942f has been approved by Eirik0

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 24, 2019

⌛️ Testing commit a80942f with merge d54f6c9...

zkbot added a commit that referenced this pull request Oct 24, 2019
depends macOS: point --sysroot to SDK

Fixes #4149
Fixes #4150
Fixes #4151
Fixes #4152
@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Oct 24, 2019

☀️ Test successful - pr-merge
Approved by: Eirik0
Pushing d54f6c9 to master...

@zkbot zkbot merged commit a80942f into zcash:master Oct 24, 2019
1 check passed
1 check passed
homu Test successful
Details
@str4d str4d added this to the v2.1.0 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.